Replaced mapbox to osmdroid (Upload Activity) #5443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # app/src/main/java/fr/free/nrw/commons/utils/PermissionUtils.java
nicolas-raoul
requested changes
Jan 16, 2024
There was a problem hiding this comment.
It works great, except that in the Image Location activity (the activity that appears when you tap the Media Details' map icon) the pin should be fixed to the map. The pin should be movable to a different latitude/longitude only in the Edit Location activity.
I added a few other minor observations. :-)
Thanks!
app/src/test/kotlin/fr/free/nrw/commons/locationpicker/LocationPickerActivityUnitTests.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/fr/free/nrw/commons/LocationPicker/LocationPickerActivity.java
Outdated
Show resolved
Hide resolved
|
Hi @nicolas-raoul , I have made all the suggested changes ;-). Should we change the color of marker in location picker similar to #5440 ? WhatsApp.Video.2024-01-16.at.23.50.38_648eadee.mp4 |
|
Your screencast looks great! |
nicolas-raoul
approved these changes
Jan 17, 2024
|
Thank you ;) for feedback @nicolas-raoul , I have changed the color of selected location marker 9814bfe
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixes #5414
Tests performed (required)
Tested betaDebug on Samsung S21 FE with API level 33.
Screenshots (for UI changes only)
https://github.com/commons-app/apps-android-commons/assets/114223204/69139492-02bf-4f35-8ff1-c0ec46871c85