Fix Crash in LocationPickerActivity when device configuration is changed

[shashankiitbhu]

Description (required)

Fixes #5474

What changes did you make and why?
Identified and fixed a critical issue in the open-source project related to the LocationPickerActivity.
The crash occurred when the device configuration changed, specifically during UI mode switches (dark to light or light to dark mode)

Investigated the crash root cause, which was tied to how the activity handled UI mode changes.

Tests performed (required)

Tested 4.2.1-debug on Xiaomi 11 Lite NE with API level 33

Screenshots (for UI changes only)

WhatsApp.Video.2024-01-31.at.12.10.27.PM.mp4

[shashankiitbhu]

@nicolas-raoul Please Review this PR

[shashankiitbhu]

Hi @nicolas-raoul , is there any change required in this PR?

[ShashwatKedia]

Student Review

Screencast of Before:
https://drive.google.com/file/d/1w2wtnYh1ax3mIMfRStepET9Zl7efmLNl/view?usp=share_link

Screencast of After:
https://drive.google.com/file/d/1w9F14a22OPhHsAIgxmeHvvEa-XsV1KjL/view?usp=share_link

The crash does not happen after merging this PR, but some bugs still remain:

1. If I move the marker to some other position and then change the configuration, then that change is lost (can be seen in the 'After Screencast' ).
2. I started the process of uploading a new image and tried to add a location to it using the LocationPicker, but the app crashed Screencast when I pressed the tick icon. This does not happen if I change/update co-ordinates of an already uploaded image. Here's the Logcat for the same:

FATAL EXCEPTION: main Process: fr.free.nrw.commons, PID: 1201 java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.String fr.free.nrw.commons.Media.getFilename()' on a null object reference at fr.free.nrw.commons.coordinates.CoordinateEditHelper.addCoordinates(CoordinateEditHelper.java:84) at fr.free.nrw.commons.coordinates.CoordinateEditHelper.makeCoordinatesEdit(CoordinateEditHelper.java:63) at fr.free.nrw.commons.LocationPicker.LocationPickerActivity.updateCoordinates(LocationPickerActivity.java:356) at fr.free.nrw.commons.LocationPicker.LocationPickerActivity.placeSelected(LocationPickerActivity.java:342) at fr.free.nrw.commons.LocationPicker.LocationPickerActivity.lambda$addPlaceSelectedButton$4$fr-free-nrw-commons-LocationPicker-LocationPickerActivity(LocationPickerActivity.java:328) at fr.free.nrw.commons.LocationPicker.LocationPickerActivity$$ExternalSyntheticLambda3.onClick(Unknown Source:2) at android.view.View.performClick(View.java:7488)

It seems to be happening due to media being null, while being passed in the newly created updateCoordinates function.

[shashankiitbhu]

1. If I move the marker to some other position and then change the configuration, then that change is lost (can be seen in the 'After Screencast' ).

This one is not a bug as you haven't selected any location , you are just hovering over it so it is not saved anywhere.

[shashankiitbhu]

@ShashwatKedia Thanks for reporting the Null Pointer Exception, fixing it now

[shashankiitbhu]

@nicolas-raoul @RitikaPahwa4444 can you review and merge this , thanks

[nicolas-raoul]

Tested, fixes the crash.
Thanks!