Resolved Problems in UploadMediaDetails flow and UX #5511 #5527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
The uploadMediaDetailFragment flow had some flaws, as discussed in #5511. This PR aims to remove those flaws and improve the UX of uploadMediaDetailFragment.
Fixes #5511
What changes did you make and why?
Changed the flow of dialogs in uploadMediaDetailFragment, resolved the flickering of arrow on zooming the image and added logic to keep the location comparer from popping up several times.
Tests performed (required)
Tested prodDebug on OnePlus Nord CE 2 Lite with API level 31.
Screencasts
Resolved issue part 1 (2 dialogs popping up and no highlight in thumbnail):
https://drive.google.com/file/d/1mXXfMk_XP-jzOBqzPNaTDILO8H5p-Ey5/view?usp=sharing
Resolved issue part 2 (location comparison several times):
https://drive.google.com/file/d/1m7e1RXvqBiMcp-VkPdF6N-0fkkRwfOSR/view?usp=sharing
Resolved issue part 3 (no location dialog pops up twice):
https://drive.google.com/file/d/1lujbBtPPUEzd8ag1uYfZpmKlz65OMzfR/view?usp=sharing
Resolved issue part 4 (arrow flickers on zooming image):
https://drive.google.com/file/d/1lrGmZnJy6Zhmi2PVirw5WRPdk8ZOi5ms/view?usp=sharing