Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - Unable to Access Privacy Policy #5534

Merged
merged 2 commits into from
Feb 11, 2024

Conversation

shashankiitbhu
Copy link
Contributor

Description (required)

Fixes #5532

What changes did you make and why?
Removed a misleading check that was stopping the GitHub App to Open the Url for Privacy Policy.

Tests performed (required)

Tested 4.2.1-debug-main on {Xiaomi 11 Lite NE with API level 33

Screenshots (for UI changes only)

IF GITHUB IS NOT INSTALLED:

WhatsApp.Video.2024-02-10.at.10.03.46.AM.mp4

IF GITHUB APP IS INSTALLED:

WhatsApp.Video.2024-02-10.at.10.03.42.AM.mp4

Copy link
Member

@nicolas-raoul nicolas-raoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, it is working fine for me on Pixel 7 Android 14 (it was already working fine for me though).

@nicolas-raoul nicolas-raoul merged commit 1895bb3 into commons-app:main Feb 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Can't Open Privacy Policy
2 participants