Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes App crashes on clicking Save (EditActivity) #5670

Merged
merged 66 commits into from
Mar 30, 2024
Merged

Fixes App crashes on clicking Save (EditActivity) #5670

merged 66 commits into from
Mar 30, 2024

Conversation

kanahia1
Copy link
Contributor

Description (required)

Fixes #5632

What changes did you make and why?

Tests performed (required)

Tested prodDebug on Samsung S21 FE with API level 33.

Screenshots (for UI changes only)
Tested on same picture as in #5632

WhatsApp.Video.2024-03-28.at.21.02.47_9bd61241.mp4

kanahia1 and others added 30 commits October 21, 2023 02:32
@kanahia1
Fixed Grey empty screen at Upload wizard caption step after denying f…
b6a2151 
…iles permission
@kanahia1
Empty commit
f916e1f
@kanahia1
Merge remote-tracking branch 'origin/main'
b75193b 
# Conflicts:
#	app/src/main/java/fr/free/nrw/commons/utils/PermissionUtils.java
@kanahia1
Fixed loop issue
98473a1
@kanahia1
Created docs for earlier commits
f5f050e
@kanahia1
Fixed javadoc
1b3bd3d
@kanahia1
Merge branch 'commons-app:main' into main
9a9e285
@kanahia1
Fixed spaces
896c1d9
@kanahia1
Merge branch 'commons-app:main' into main
5ae7550
@kanahia1
Added added basic features to OSM Maps
365dd76
@kanahia1
Added search location feature
4ffafd8
@kanahia1
Added filter to Open Street Maps
2e3d690
@kanahia1
Fixed chipGroup in Open Street Maps
59d21d2
@kanahia1
Removed mapBox code
ac453df
@kanahia1
Merge branch 'commons-app:main' into main
ad564d3
@kanahia1
Removed mapBox's code
a6cbb27
@kanahia1
Reformat code
0cedf17
@kanahia1
Reformatted code
9919ac5
@kanahia1
Removed rotation feature to map
e0e0850
@kanahia1
Removed rotation files and Fixed Marker click problem
3a6365f
@kanahia1
Merge branch 'main' into main
a017314
@kanahia1
Ignored failing tests
3069518
@kanahia1
Added voice input feature
fc1855c
@kanahia1
Merge remote-tracking branch 'origin/main'
7fdd88f
@kanahia1
Fixed test cases
78666c6
@kanahia1
Merge branch 'commons-app:main' into main
c9ae0d9
@kanahia1
Merge branch 'commons-app:main' into main
3972967
@kanahia1
Changed caption and description text
0dc6b11
@kanahia1
Merge branch 'main' into main
bcda966
@kanahia1
Merge branch 'commons-app:main' into main
23459cb
kanahia1 and others added 25 commits January 19, 2024 02:13
@kanahia1
Merge branch 'main' into issue5439
bd6e039
@kanahia1
Merge branch 'commons-app:main' into issue5439
bcca120
@kanahia1
Merge remote-tracking branch 'origin/issue5439' into issues5439
1df5e2c
@kanahia1
Merge branch 'commons-app:main' into issue5439
9380f47
@kanahia1
Merge remote-tracking branch 'origin/issue5439' into issues5439
e26d270
@kanahia1
Removed mapbox code1
6b9f261
@kanahia1
Removed mapbox code2
1ed9064
@kanahia1
Fixed failing tests
60138b5
@kanahia1
Merge branch 'main' into issues5439
a0ef312
@kanahia1
Fixed failing due to merging
dd31041
@kanahia1
Added feature to save nearby places as GPX and KML
4ff3243
@kanahia1
Merge branch 'issue953' of https://github.com/kanahia1/apps-android-c…
c459325 
…ommons into issue953
@kanahia1
Merge branch 'main' into issue953
f6dc152
@kanahia1
Merge branch 'commons-app:main' into issue953
acacf03
@kanahia1
Fixed error caused by null
c633593
@kanahia1
Merge branch 'commons-app:main' into issue953
0b32ca3
@kanahia1
Improved UX for Nearby Export
c043d07
@kanahia1
Merge remote-tracking branch 'origin/issue953' into issue953
9762d6c
@kanahia1
Delete app/src/main/res/values-yue-hant directory
094ab33
@kanahia1
Fixed internationalization issue
3c864d8
@kanahia1
Merge remote-tracking branch 'origin/issue953' into issue953
38c246a
@kanahia1
Merge branch 'main' into issue953
65f0dab
@kanahia1
Merge branch 'commons-app:main' into issue953
9ea8abd
@kanahia1
Fixed crash
a3a2dfb
@kanahia1
Merge remote-tracking branch 'origin/issue953' into issue953
290d33c
nicolas-raoul
nicolas-raoul reviewed Mar 29, 2024
View reviewed changes
Copy link
Member

@nicolas-raoul nicolas-raoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No more crash, thanks!
Saving still fails, but I guess that's another issue?

@neeldoshii
Copy link
Contributor

Thank you for the contribution.

This does indeed solve the app crash, but still few nitpicks

  1. You have 66 commits can you perform git reset and have one.
  2. The reason I am not convinced in this is because this PR Fix custom picker not consider rotated image #5569 solves exif null pointer as well as it handles the saving of rotated image. Would you mind updating the code to saving the rotated image and also considering Fix custom picker not consider rotated image #5569 (comment) to fix security issues of exif data.

@kanahia1
Copy link
Contributor Author

kanahia1 commented Mar 29, 2024 •
edited
Loading

@nicolas-raoul, Thanks for the review. Sure we can open a new issue for the saving.

@nicolas-raoul nicolas-raoul merged commit 7dd00ef into commons-app:main Mar 30, 2024
1 check passed
@nicolas-raoul
Copy link
Member

It is true that git rebase would have made the commits of this PR cleaner. I suggest always running it before sending a PR, it not only makes review easier, but can help contributors spot problems that would otherwise be hard to notice.

@neeldoshii Would you like to create an issue (and possibly PR) for what you think are the next steps on this? :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-raoul nicolas-raoul nicolas-raoul left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: App crashes on clicking Save (EditActivity)
3 participants
@kanahia1 @neeldoshii @nicolas-raoul