Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-Ecla: Contributors acknowledgment remain authorized after remove the user from the approved list #4325

Open
thakurveerendras opened this issue May 14, 2024 · 9 comments
Assignees
Labels
bug Something isn't working internal Internal tickets

Comments

@thakurveerendras
Copy link
Contributor

Summary

Contributors acknowledgment remain authorized after remove the user from the approved list in auto-ecla case

Background

  1. Go to the org dashboard & login with valid credentials
  2. Add PR
  3. Enable Auto-Ecla toggle button
  4. Add the user email address under the approval list
  • See-user added under Contributors acknowledgment with authorized state
  • See-PR also becomes covered
  1. Now remove user from the approval list
  • See- Contributors acknowledgment remains in the authorized state
  • See-PR become not covered > expected

Expected behavior

User should become unauthorized

Screenshots

image

@thakurveerendras thakurveerendras added the bug Something isn't working label May 14, 2024
@thakurveerendras
Copy link
Contributor Author

Refer to PR for more details: sun-test-org/repo1#115
image

@thakurveerendras
Copy link
Contributor Author

On prod, added approval contributor not showing under the list, Kindly review
Refer to the below details:

Link: https://organization.lfx.linuxfoundation.org/foundation/a092M00001IkZSNQA3/project/a092M00001IdwOGQAZ/cla

image

@mlehotskylf
Copy link
Contributor

@thakurveerendras please confirm if this is regression issue. Thanks!

@mlehotskylf
Copy link
Contributor

mlehotskylf commented May 16, 2024

@thakurveerendras confirmed this is working fine in PROD but this is corner case.

@mlehotskylf mlehotskylf added the internal Internal tickets label May 22, 2024
@mlehotskylf
Copy link
Contributor

To be completed by EOD today (May 23rd).

@nickmango
Copy link
Collaborator

@thakurveerendras kindly verify
Tried with your user as this appeared to have been an issue with the ICLA check pass hence the Authorized state

Image

@thakurveerendras
Copy link
Contributor Author

Issue is still reproducible at my end. Note that the user is under the ICLA list with a disabled state
Refer below details

image
image
image

@mlehotskylf
Copy link
Contributor

@nickmango to sync with @thakurveerendras on this.

@nickmango
Copy link
Collaborator

Highlighted 2 issues in the discussion with @thakurveerendras

  • Mismatch in checks as highlted above by @thakurveerendras
  • Email that is associated with a GithubAcct and is added/removed on the approval list still shows the GH user as Authorized

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working internal Internal tickets
Projects
None yet
Development

No branches or pull requests

3 participants