Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRE_PACKAGE_UNINSTALL is never fired #6261

Closed
SebCorbin opened this issue Mar 14, 2017 · 2 comments
Closed

PRE_PACKAGE_UNINSTALL is never fired #6261

SebCorbin opened this issue Mar 14, 2017 · 2 comments

Comments

@SebCorbin
Copy link

Problem
Willing to contribute to https://github.com/cweagans/composer-patches and https://github.com/derhasi/composer-preserve-paths, I discovered that PackageEvents::PRE_PACKAGE_UNINSTALL is documented but never used

Question
So I'm wondering if it should be dispatched by composer itself on $this->composer->getInstallationManager()->uninstall() or by the module calling this?

@alcohol
Copy link
Member

alcohol commented Mar 15, 2017

This is either a bug, or it was simply never implemented. Either way, a pull request is welcome :-).

@SebCorbin
Copy link
Author

So my bad, this morning I dug up in the code and it seems implemented here https://github.com/composer/composer/blob/master/src/Composer/Installer.php#L572 bu the thing is, the number of arguments to reproduce this is too damn high :)

I tried a hotfix for the patch plugin here SebCorbin/composer-patches@1cb9bac and it is ugly
I don't want to break the API so I'm not gonna write a pull request, and now that I've found why I'm frustrated feel free to close this issue

@alcohol alcohol closed this as completed Mar 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants