New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support larger MAJOR version numbers #150

Closed

onethumb opened this issue Feb 1, 2023 · 0 comments

Contributor

onethumb commented Feb 1, 2023

We prefer to use CalVer + SemVer (YYYYMMDD as MAJOR) for versioning.
Other software, like npm, supports this: https://github.com/npm/node-semver/blob/bdda212f4f6126a1b8821dc0731a17fdc2fc533f/classes/semver.js#L48
Composer breaks with an invalid version string because it's limited to 5 digits:

root@0c6964ad69d6:/var/project# COMPOSER_ROOT_VERSION=20230131.0.0 composer install

  [UnexpectedValueException]
  Invalid version string "20230131.0.0"

While we're at it, we may as well be future-proof (support & test YYYYMMDDhhmm and PHP_INT_MAX).

PR has been submitted: #149

The text was updated successfully, but these errors were encountered:

Seldaek closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment