Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[service] remove diligentgraphics-* recipes #8151

Closed
AndreyMlashkin opened this issue Nov 22, 2021 · 10 comments
Closed

[service] remove diligentgraphics-* recipes #8151

AndreyMlashkin opened this issue Nov 22, 2021 · 10 comments
Assignees

Comments

@AndreyMlashkin
Copy link
Contributor

These recipes were originally added for diligentcore recipe:
#7804 (comment)

They should build 3rd party lib forks from Diligent as discussed here:
#7826

As I have managed to build diligent with the latest versions of the official recipes, there is no need for these diligentgraphics-* recipes recipes, please delete them

@SSE4
Copy link
Contributor

SSE4 commented Nov 22, 2021

sorry, but we're not removing any recipes. conan-center is immutable, as recipes will be always there.
there might be already consumers who consume that specific recipe (e.g. via lockfiles).
we can only deprecate it and discourage consumers from using it.

@AndreyMlashkin
Copy link
Contributor Author

They were added a couple weeks ago for one specific purpose, I don't think anyone is interested in these recipes

@ericLemanissier
Copy link
Contributor

You could make the recipe empty, and always raise an exception in validate, but it's a bit harsh to consumers

@SSE4
Copy link
Contributor

SSE4 commented Nov 22, 2021

You could make the recipe empty, and always raise an exception in validate, but it's a bit harsh to consumers

for the record, it will be a new recipe revision. for consumers who rely on the specific (previous) revision, it won't change.

@SpaceIm
Copy link
Contributor

SpaceIm commented Nov 22, 2021

Removing these recipes in the repo is fine I think (and neater). We can eventually deprecate them in a commit, then remove them in conan-center-index (they won't be removed from conan-center).

@ericLemanissier
Copy link
Contributor

ericLemanissier commented Nov 22, 2021

I'd say it better to leave a message with an exception as a first step (to explain why this package should not be used, and which package should be used instead). Then, it is ok to remove completely (requiring admin rights, because the bot does not agree to remove folders)

@SSE4
Copy link
Contributor

SSE4 commented Nov 22, 2021

I'd say it better to live a message with an exception as a first step, the remove completely (requiring admin rights, because the bot does not agree to remove folders)

yes, CI will fail for such PR. ofcourse, we can force merge it manually, but I don't want to open pandora's box right now. we already know an unfortunate leftpad precident, and if people will start to remove recipes they contributed in the past, it may ruin other people's workflows.

I will propose this case for the next internal discussion within our development team and let you know about our decision.
I can imagine there will be valid cases where we may want to remove some recipes (e.g. if we discover they contain some malicious code, or proprietary/leaked code). that's obviously not the case of diligentgraphics, but if you think it's something to remove because it's harmful, we may consider doing an exception.

@SSE4 SSE4 self-assigned this Nov 22, 2021
@Croydon
Copy link
Contributor

Croydon commented Nov 22, 2021

I would rather want to keep the recipes in git, so that names are not re-used by accident (unlikely in this case, but rules should be stringent).

@danimtb
Copy link
Member

danimtb commented Dec 2, 2021

We discussed this topic and we agreed to handle it the same way we did with other recipes. Adding the deprecated attribute should be enough https://docs.conan.io/en/latest/reference/conanfile/attributes.html#deprecated. We don't have a special treatment in the CI pipeline to avoid building deprecated recipes yet, but that would be a future improvement.

@ericLemanissier
Copy link
Contributor

the recipes are now mark deprecated, so this issue can probably be closed right ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants