-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[service] remove diligentgraphics-* recipes #8151
Comments
sorry, but we're not removing any recipes. conan-center is immutable, as recipes will be always there. |
They were added a couple weeks ago for one specific purpose, I don't think anyone is interested in these recipes |
You could make the recipe empty, and always raise an exception in validate, but it's a bit harsh to consumers |
for the record, it will be a new recipe revision. for consumers who rely on the specific (previous) revision, it won't change. |
Removing these recipes in the repo is fine I think (and neater). We can eventually deprecate them in a commit, then remove them in conan-center-index (they won't be removed from conan-center). |
I'd say it better to leave a message with an exception as a first step (to explain why this package should not be used, and which package should be used instead). Then, it is ok to remove completely (requiring admin rights, because the bot does not agree to remove folders) |
yes, CI will fail for such PR. ofcourse, we can force merge it manually, but I don't want to open pandora's box right now. we already know an unfortunate I will propose this case for the next internal discussion within our development team and let you know about our decision. |
I would rather want to keep the recipes in git, so that names are not re-used by accident (unlikely in this case, but rules should be stringent). |
We discussed this topic and we agreed to handle it the same way we did with other recipes. Adding the |
the recipes are now mark deprecated, so this issue can probably be closed right ? |
These recipes were originally added for diligentcore recipe:
#7804 (comment)
They should build 3rd party lib forks from Diligent as discussed here:
#7826
As I have managed to build diligent with the latest versions of the official recipes, there is no need for these diligentgraphics-* recipes recipes, please delete them
The text was updated successfully, but these errors were encountered: