-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[package] google-cloud-cpp/1.31.1: Does not build with gcc 11 #9679
Comments
Likely the usual issue related to C++ standard and incoherency in the way abseil was built and consumed. Does it work if you try to force compiler.cppstd to 17? |
might be relevant: #7443 |
@SpaceIm yes I can build with |
Didn't have the time to experiment, but I've proposed a solution in abseil recipe: #7443 (comment) |
@SpaceIm I've tried to pin ABI according to your method in #9703 |
Maybe because google-cloud-cpp forces C++11 instead of relying on cxx_std_11 feature? https://github.com/googleapis/google-cloud-cpp/blob/8e39dd5c711c3209da4273fa554a705eba82f53c/CMakeLists.txt#L31-L41 |
maybe. how should we deal with it in context of recipe(s)? reject other configurations besides C++11? |
I would say fix The issue I'm suspecting is the last sentence of #7443 (comment):
so:
|
but shouldn't it transitively receive |
It should, but conan generators are not able to emulate cmake features like cxx_std_11. And even with that, CXX_STANDARD in google-cloud-cpp defeats cxx features. |
commenting this line: https://github.com/conan-io/conan-center-index/blob/master/recipes/google-cloud-cpp/all/conanfile.py#L110 |
I think I'll fight with this issue here: #10499 Wish me luck! 😅 |
In On GCP we are forcing C++11 ( I'm not talking about new versions, but I would have expected that combination to work. Althoug I'm sure I'm missing something, I need to read more. |
Oh... and we have |
Having a look at
My Conan package (GCC 11) has value 1, so consumers require C++17... So, even if The problem here is that we should be able to propagate downstream the minimal requirement (after parsing this
|
I'm proposing these changes to |
Itis not a minimal requirement. It is cppstd==17. And I think that is a bug. You also cant compile with cpp20 Edit: I think it is cppstd == default cppstd of that compiler |
I've tested it using docker image
If using GCC11, in my proposal, the Edit.- Only tested latest version |
Package and Environment Details (include every applicable attribute)
Conan profile
The toolchain only contains some definitions for gcc-11 and does not really matter it will also break with a default gcc 11 build.
Steps to reproduce (Include if Applicable)
Logs (Include/Attach if Applicable)
Click to expand log
The text was updated successfully, but these errors were encountered: