-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[google-cloud-cpp] add v2.28.0 version #24899
[google-cloud-cpp] add v2.28.0 version #24899
Conversation
This comment has been minimized.
This comment has been minimized.
@jcar87 - Hey, I could use some help. It looks like there is not a prebuilt Is it possible to build a gRPC package in this configuration and retry the build? Should I change something in
|
@dbolduc Why are there 3 versions in the CI pipeline and not just google-cloud-cpp/2.28.0? |
We're looking into this! in this case it is because of the version of abseil being used in this recipe, you could probably expand it to cover the same range as the grpc recipe:
the recipe file is shared amongst multiple versions, so if its modified, a new recipe revision needs to be published for the earlier versions as well |
@jcar87 Thanks for the insight, I wasn't aware of this. |
Worth a try. Thanks for looking! 🤞 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
01bc3de
to
c9542a4
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 6 (
Conan v2 pipeline ✔️
All green in build 8 ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me, thanks a lot for taking the time to get this thru to the finish line!
@@ -35,13 +37,15 @@ | |||
|
|||
# Used in _generate_proto_requires(): the *.deps files are generated from | |||
# Bazel and contain a few targets that have incorrect names for CMake. | |||
# | |||
# This list maps onto google_cloud_cpp_load_protodeps()'s `targets_substitutions`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for taking the time to add some more context in here! We really appreciate it :)
ping? we are so close... |
google-cloud-cpp/2.28.0
google-cloud-cpp
.external/googleapis/
are always compiled googleapis/google-cloud-cpp#8022SelectMSVCRuntime.cmake
googleapis/google-cloud-cpp#13777Tested with the following on linux: