Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[google-cloud-cpp] add v2.28.0 version #24899

Merged
merged 3 commits into from
Sep 2, 2024

Conversation

dbolduc
Copy link
Contributor

@dbolduc dbolduc commented Aug 12, 2024

google-cloud-cpp/2.28.0

Tested with the following on linux:

for v in "2.28.0" "2.19.0" "2.15.1"; do
  env CC=gcc-11 CXX=g++-11 conan create --build missing  --build-require  --version ${v} recipes/google-cloud-cpp/2.x
done

@conan-center-bot conan-center-bot added Failed Missing dependencies Build failed due missing dependencies in Conan Center labels Aug 12, 2024
@conan-center-bot

This comment has been minimized.

@dbolduc
Copy link
Contributor Author

dbolduc commented Aug 13, 2024

@jcar87 - Hey, I could use some help. It looks like there is not a prebuilt grpc/1.54.3 package with compiler.cppstd=17. What should I do about this?

Is it possible to build a gRPC package in this configuration and retry the build? Should I change something in google-cloud-cpp.

ERROR: Missing prebuilt package for 'grpc/1.54.3'. You can try:
    - List all available packages using 'conan list "grpc/1.54.3:*" -r=remote'
    - Explain missing binaries: replace 'conan install ...' with 'conan graph explain ...'
    - Try to build locally from sources using the '--build=grpc/1.54.3' argument

More Info at 'https://docs.conan.io/2/knowledge/faq.html#error-missing-prebuilt-package'

@saschasc
Copy link

@dbolduc Why are there 3 versions in the CI pipeline and not just google-cloud-cpp/2.28.0?

@jcar87
Copy link
Contributor

jcar87 commented Aug 13, 2024

@jcar87 - Hey, I could use some help. It looks like there is not a prebuilt grpc/1.54.3 package with compiler.cppstd=17. What should I do about this?

Is it possible to build a gRPC package in this configuration and retry the build? Should I change something in google-cloud-cpp.

ERROR: Missing prebuilt package for 'grpc/1.54.3'. You can try:
    - List all available packages using 'conan list "grpc/1.54.3:*" -r=remote'
    - Explain missing binaries: replace 'conan install ...' with 'conan graph explain ...'
    - Try to build locally from sources using the '--build=grpc/1.54.3' argument

More Info at 'https://docs.conan.io/2/knowledge/faq.html#error-missing-prebuilt-package'

We're looking into this! in this case it is because of the version of abseil being used in this recipe, you could probably expand it to cover the same range as the grpc recipe:

"abseil/20230125.3" -> "abseil/[>=20230125.3 <=20230802.1]"

@dbolduc Why are there 3 versions in the CI pipeline and not just google-cloud-cpp/2.28.0?

the recipe file is shared amongst multiple versions, so if its modified, a new recipe revision needs to be published for the earlier versions as well

@saschasc
Copy link

@jcar87 Thanks for the insight, I wasn't aware of this.

@dbolduc
Copy link
Contributor Author

dbolduc commented Aug 13, 2024

you could probably expand it to cover the same range as the grpc recipe:

Worth a try. Thanks for looking! 🤞

@conan-center-bot conan-center-bot removed the Missing dependencies Build failed due missing dependencies in Conan Center label Aug 13, 2024
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@dbolduc dbolduc marked this pull request as ready for review August 18, 2024 13:37
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 6 (c9542a452e164ae44fba7707713e9fe5db6a6ce2):

  • google-cloud-cpp/2.28.0:
    All packages built successfully! (All logs)

  • google-cloud-cpp/2.19.0:
    All packages built successfully! (All logs)

  • google-cloud-cpp/2.15.1:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 8 (c9542a452e164ae44fba7707713e9fe5db6a6ce2):

  • google-cloud-cpp/2.15.1:
    All packages built successfully! (All logs)

  • google-cloud-cpp/2.19.0:
    All packages built successfully! (All logs)

  • google-cloud-cpp/2.28.0:
    All packages built successfully! (All logs)

@AbrilRBS AbrilRBS self-assigned this Aug 19, 2024
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, thanks a lot for taking the time to get this thru to the finish line!

@@ -35,13 +37,15 @@

# Used in _generate_proto_requires(): the *.deps files are generated from
# Bazel and contain a few targets that have incorrect names for CMake.
#
# This list maps onto google_cloud_cpp_load_protodeps()'s `targets_substitutions`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for taking the time to add some more context in here! We really appreciate it :)

@dbolduc
Copy link
Contributor Author

dbolduc commented Aug 28, 2024

ping? we are so close...

@conan-center-bot conan-center-bot merged commit 2606861 into conan-io:master Sep 2, 2024
20 checks passed
@dbolduc dbolduc deleted the google-cloud-cpp-v2-28-0 branch September 3, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants