Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define abstract env-vars in package_info() for editable and unix_path #12499

Closed
memsharded opened this issue Nov 9, 2022 · 2 comments · Fixed by #12598
Closed

Define abstract env-vars in package_info() for editable and unix_path #12499

memsharded opened this issue Nov 9, 2022 · 2 comments · Fixed by #12598
Milestone

Comments

@memsharded
Copy link
Member

Comes from #12192 (comment)_

Some packages want to define env-vars with paths, and they often use self.package_folder for it, so this is broken for editable packages, for example, in which package_folder=None. It also doesn't work for other abstractions over paths as unix_paths, which depend on the consumer, not the package creator.

Let's investigate some mechanism that allow to define abstract env-vars for PATHs that are resolved better in the consumer side.

@franramirez688
Copy link
Contributor

This issue is related to #12477

@SpaceIm
Copy link
Contributor

SpaceIm commented Dec 21, 2022

It also doesn't work for other abstractions over paths as unix_paths, which depend on the consumer, not the package creator.

Did #12598 fix this specific issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants