Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] BazelDeps generator gives Incorrect link order for multi-lib packages #16949

Closed
BoelGerhardt opened this issue Sep 6, 2024 · 1 comment · Fixed by #17109
Closed

[bug] BazelDeps generator gives Incorrect link order for multi-lib packages #16949

BoelGerhardt opened this issue Sep 6, 2024 · 1 comment · Fixed by #17109
Assignees
Labels
Milestone

Comments

@BoelGerhardt
Copy link

Describe the bug

Environment Details

Operating System+version: All
Compiler+version: Not relevant
Conan version: 1.62 and later
Python version: All

Description

This is basically a re-opening of #11559.

The original issue was that if running Buildifier on the generated bazel BUILD files, it would sort deps in the wrong order for multi-lib packages (like openssl or xmlsec). This was fixed in #11560 which added a # do not sort comment to the deps section, so that buildifier would not change the order of deps.

Now the # do not sort comment is no longer added, so buildifier will sort the deps again. (It also looks like the BUILD files might already be "prettified", i.e. have the deps sorted alphabetically when generated by conan). This causes link errors for e.g. openssl and xmlsec, due to their component libraries needing to be in a non-alphabetical order.

The issue re-appeared in conan version 1.62. I believe this is the change that broke it: #14959

How to reproduce it

See #11559

@memsharded
Copy link
Member

This has been fixed in #17109, will be available in next Conan 2.9, thanks for your feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants