Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STW - Digital IO #7

Open
rickyelopez opened this issue May 3, 2022 · 1 comment · May be fixed by #9
Open

STW - Digital IO #7

rickyelopez opened this issue May 3, 2022 · 1 comment · May be fixed by #9
Labels
help wanted Extra attention is needed new feature This issue relates to a new feature STW Tracker for all STW issues

Comments

@rickyelopez
Copy link
Member

rickyelopez commented May 3, 2022

relates to #5

I already implemented the analog input functionality in the IO module. This should be refactored to IO_analog or something to that effect so that we can now add an IO_digital module.

This module should be a lot more simple, since all it has to do define ISRs which will update the appropriate variable in the module struct based on the corresponding physical IO. We could also explore adding debouncing here eventually, but lets focus on confirming that the PCB works. Also, the hardware debouncing I added to the PCB should be sufficient (hopefully).

Would be nice to keep in mind modularity of this. Ideally, this structure should be as abstracted as possible so that we can make this a common module that multiple ECUs (ideally even with different chips) should be able to leverage it.

@rickyelopez rickyelopez added new feature This issue relates to a new feature help wanted Extra attention is needed labels May 3, 2022
@JoshLafleur
Copy link
Collaborator

Starting development on remote branch as cannot push. Discussing with @rickyelopez

@JoshLafleur JoshLafleur self-assigned this May 31, 2022
@JoshLafleur JoshLafleur removed the help wanted Extra attention is needed label May 31, 2022
@rickyelopez rickyelopez linked a pull request Jul 8, 2022 that will close this issue
@JoshLafleur JoshLafleur added the STW Tracker for all STW issues label Oct 2, 2024
@JoshLafleur JoshLafleur removed their assignment Oct 2, 2024
@JoshLafleur JoshLafleur added the help wanted Extra attention is needed label Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed new feature This issue relates to a new feature STW Tracker for all STW issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants