Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROMs not included in release #19

Open
1 task done
pseudo-rnd-thoughts opened this issue Oct 11, 2024 · 2 comments
Open
1 task done

ROMs not included in release #19

pseudo-rnd-thoughts opened this issue Oct 11, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@pseudo-rnd-thoughts
Copy link

pseudo-rnd-thoughts commented Oct 11, 2024

Solution to issue cannot be found in the documentation.

  • I checked the documentation.

Issue

@Tobias-Fischer Thanks for maintaining the project, in v0.9, we added the ROMs within the PyPI wheels (Farama-Foundation/Arcade-Learning-Environment#516)
However, the conda doesn't seem to have updated to do this. I would guess that during the compile stage, the ROMs are not downloaded and then packaged.
Also, there don't seem to be any tests being run unless I've missed something

This is affecting Gymnasium downstream which uses the ROMs with ale-py (conda-forge/gymnasium-feedstock#41)

Installed packages

.

Environment info

.

@pseudo-rnd-thoughts pseudo-rnd-thoughts added the bug Something isn't working label Oct 11, 2024
@Tobias-Fischer
Copy link
Contributor

Would you be ok to open a PR @pseudo-rnd-thoughts? Or even better take over maintenance here?

@pseudo-rnd-thoughts
Copy link
Author

I don't actually understand conda-forge at all, so I'm happy to be added as maintainer but I probably can't help too much.
I'll have a look at what is happening for a PR but I don't understand the conda compile process at all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants