Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restart new migration for protobuf 4.23.3 & grpc 1.56 #4620

Merged
merged 1 commit into from
Jul 1, 2023
+4 −4
Merged

restart new migration for protobuf 4.23.3 & grpc 1.56 #4620

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions recipe/migrations/protobuf423.yaml → ...igrations/libprotobuf4233_libgrpc156.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
__migrator:
build_number: 1
kind: version
migration_number: 2
migration_number: 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we increase the number instead of decreasing it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or is this different as it stops one and starts another migration?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I renamed the migration, so the PR names are less confusing. Rather than a 3rd "Rebuild for protobuf423", it would be "Rebuild for libprotobuf4233_libgrpc156".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or is this different as it stops one and starts another migration?

Exactly

libgrpc:
- '1.54'
- '1.55'
- '1.56'
libprotobuf:
- '3.21'
- '4.23.2'
migrator_ts: 1684932016.2362208
- '4.23.3'
migrator_ts: 1688154716.9176981