Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set CONDA_BLD_PATH when using pixi during osx build #2148

Merged
merged 10 commits into from
Nov 26, 2024
Merged

Set CONDA_BLD_PATH when using pixi during osx build #2148

merged 10 commits into from
Nov 26, 2024
+35 −5

Conversation

hadim
Copy link
Member

@hadim hadim commented Nov 20, 2024 •
edited
Loading

Checklist

  • Added a news entry
  • Regenerated schema JSON if schema altered (python conda_smithy/schema.py)

This is an attempt to fix #2145. You can see it in action at conda-forge/docling-parse-feedstock#3

Note the fix is a simple and naive patch but looks fragile to me. Please let me know if you can think of another solution.

@hadim hadim requested a review from a team as a code owner November 20, 2024 16:14
@hadim hadim mentioned this pull request Nov 20, 2024
Merged
5 tasks
beckermr
beckermr previously requested changes Nov 20, 2024
View reviewed changes
Copy link
Member

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should set this on all platforms?

Also, the code that finds the outputs is in the ci-setup feedstock. We need to consult that code to ensure what we are doing here works with it.

jaimergp
jaimergp reviewed Nov 26, 2024
View reviewed changes
conda_smithy/templates/run_osx_build.sh.tmpl Outdated
@@ -9,6 +9,15 @@ set -xe
MINIFORGE_HOME=${MINIFORGE_HOME:-${HOME}/miniforge3}
MINIFORGE_HOME=${MINIFORGE_HOME%/} # remove trailing slash
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can include this blob from staged-recipes here instead.

@jaimergp
Copy link
Member

jaimergp commented Nov 26, 2024 •
edited
Loading

I wonder if we should set this on all platforms?

Yea I think it wouldn't hurt. We are doing it in staged-recipes.

Edit: I took a look and this is the situation:

  • For Linux, this is handled via the hardcoded condarc in build_steps.sh
  • For macOS, we were not setting anything til now.
  • For Windows, it's dealt with in the GHA / Azure variables (so we can use D:\bld), and if not set, conda-forge-ci-setup will set it to C:\bld.

So I think we are fine for now. I left a couple comments in case we wonder in the future.

@jaimergp
Copy link
Member

Testing at conda-forge/docling-parse-feedstock#5

@hadim
Copy link
Member Author

hadim commented Nov 26, 2024

Thank you!

@beckermr beckermr enabled auto-merge (squash) November 26, 2024 22:20
@beckermr beckermr merged commit 0e1d50f into conda-forge:main Nov 26, 2024
2 checks passed
@hadim hadim deleted the pixi_osx_bld_path branch November 26, 2024 22:27
@jaimergp jaimergp mentioned this pull request Nov 27, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaimergp jaimergp jaimergp left review comments

@beckermr beckermr beckermr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

validate_recipe_outputs fails with pixi
3 participants
@hadim @jaimergp @beckermr