Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild for protobuf423 #48

Merged

Conversation

regro-cf-autotick-bot
Copy link
Contributor

@regro-cf-autotick-bot regro-cf-autotick-bot commented May 25, 2023

This PR has been triggered in an effort to update protobuf423.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.

Closes #29

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/5078512627, please use this URL for debugging.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@lidavidm
Copy link
Contributor

I guess Protobuf pulls in Abseil now and OpenTelemetry has a bundled, incompatible(?) Abseil.

WITH_STL=ON mostly fixes this (by telling it not to use its homegrown STL replacements) but doesn't fix everything.

I see they also have a 1.9.1 release in progress; I'll try building with main and see if they fixed the Protobuf issues already, else I'll try to report upstream

@lidavidm
Copy link
Contributor

Well, main doesn't fix anything.

@lidavidm
Copy link
Contributor

Aha, it's open-telemetry/opentelemetry-cpp#2095

@h-vetinari
Copy link
Member

Will rebase once #49 is in

@h-vetinari h-vetinari force-pushed the rebuild-protobuf423-0-1_h734d09 branch 2 times, most recently from 9ec34ae to 000cb55 Compare May 26, 2023 14:00
@h-vetinari h-vetinari force-pushed the rebuild-protobuf423-0-1_h734d09 branch 3 times, most recently from 0813d67 to 89a6d62 Compare May 26, 2023 16:24
@h-vetinari h-vetinari force-pushed the rebuild-protobuf423-0-1_h734d09 branch from f837972 to 3528fcf Compare May 27, 2023 00:21
@h-vetinari
Copy link
Member

For posterity / searchability, the missing protobuf symbol on osx

[16/134] Linking CXX shared library libopentelemetry_proto.dylib
FAILED: libopentelemetry_proto.dylib 
: && $BUILD_PREFIX/bin/x86_64-apple-darwin13.4.0-clang++ -march=core2 -mtune=haswell -mssse3 -ftree-vectorize -fPIC -fPIE -fstack-protector-strong -O2 -pipe -stdlib=libc++ -fvisibility-inlines-hidden -fmessage-length=0 -isystem $PREFIX/include -fdebug-prefix-map=$SRC_DIR=/usr/local/src/conda/opentelemetry-sdk-1.9.1 -fdebug-prefix-map=$PREFIX=/usr/local/src/conda-prefix -D_LIBCPP_DISABLE_AVAILABILITY -O3 -DNDEBUG -isysroot /Applications/Xcode_13.2.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.9.sdk -mmacosx-version-min=10.9 -dynamiclib -Wl,-headerpad_max_install_names -Wl,-pie -Wl,-headerpad_max_install_names -Wl,-dead_strip_dylibs -Wl,-rpath,$PREFIX/lib -L$PREFIX/lib -o libopentelemetry_proto.dylib -install_name @rpath/libopentelemetry_proto.dylib CMakeFiles/opentelemetry_proto.dir/generated/third_party/opentelemetry-proto/opentelemetry/proto/common/v1/common.pb.cc.o CMakeFiles/opentelemetry_proto.dir/generated/third_party/opentelemetry-proto/opentelemetry/proto/resource/v1/resource.pb.cc.o CMakeFiles/opentelemetry_proto.dir/generated/third_party/opentelemetry-proto/opentelemetry/proto/trace/v1/trace.pb.cc.o CMakeFiles/opentelemetry_proto.dir/generated/third_party/opentelemetry-proto/opentelemetry/proto/logs/v1/logs.pb.cc.o CMakeFiles/opentelemetry_proto.dir/generated/third_party/opentelemetry-proto/opentelemetry/proto/metrics/v1/metrics.pb.cc.o CMakeFiles/opentelemetry_proto.dir/generated/third_party/opentelemetry-proto/opentelemetry/proto/collector/trace/v1/trace_service.pb.cc.o CMakeFiles/opentelemetry_proto.dir/generated/third_party/opentelemetry-proto/opentelemetry/proto/collector/logs/v1/logs_service.pb.cc.o CMakeFiles/opentelemetry_proto.dir/generated/third_party/opentelemetry-proto/opentelemetry/proto/collector/metrics/v1/metrics_service.pb.cc.o  $PREFIX/lib/libprotobuf.dylib && :
ld: warning: -pie being ignored. It is only used when linking a main executable
Undefined symbols for architecture x86_64:
  "google::protobuf::internal::ThreadSafeArena::thread_cache_", referenced from:
      google::protobuf::RepeatedField<unsigned long long>::GrowNoAnnotate(int, int) in metrics.pb.cc.o
      google::protobuf::RepeatedField<double>::GrowNoAnnotate(int, int) in metrics.pb.cc.o
ld: symbol(s) not found for architecture x86_64

is due to the fact how protobuf changes some function definitions based on the presence of PROTOBUF_USE_DLLS, even when it's not on windows.

@h-vetinari h-vetinari force-pushed the rebuild-protobuf423-0-1_h734d09 branch from b0f0880 to 4f35798 Compare May 27, 2023 04:07
@h-vetinari h-vetinari marked this pull request as ready for review May 27, 2023 04:38
@h-vetinari h-vetinari requested a review from xhochy May 27, 2023 04:38
@h-vetinari h-vetinari requested a review from kkraus14 May 27, 2023 04:38
@xhochy xhochy merged commit 062fd2e into conda-forge:main May 27, 2023
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the rebuild-protobuf423-0-1_h734d09 branch May 27, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should we build with STL and/or ABSEIL support?
4 participants