Windows + CUDA (redux) #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
h-vetinari
force-pushed
the
win_cuda
branch
2 times, most recently
from
01404ed to
67c3f0b
Compare
h-vetinari
force-pushed
the
win_cuda
branch
7 times, most recently
from
7f4578c to
c0bf29f
Compare
This was referenced Mar 5, 2021
facebook-github-bot
pushed a commit
to facebookresearch/faiss
that referenced
this pull request
Apr 2, 2021
Summary: After initial positive feedback to the idea in #1741 from mdouze, here are the patches I currently have as a basis for discussion. Matthijs suggests to not bother with the deprecation warnings at all, which is fine for me as well, though I would normally still advocate to provide users with _some_ advance notice before removing parts of an interface. Fixes #1741 PS. The deprecation warning is only shown once per session (per class) PPS. I have tested in conda-forge/faiss-split-feedstock#32 that the respective classes remain available both through `import faiss` and `from faiss import *`. Pull Request resolved: #1742 Reviewed By: mdouze Differential Revision: D26978886 Pulled By: beauby fbshipit-source-id: b52e2b5b5b0117af7cd95ef5df3128e9914633ad
h-vetinari
force-pushed
the
win_cuda
branch
5 times, most recently
from
b557731 to
de7a4c7
Compare
This reverts commit be141cf.
This reverts commit 66f583e.
Also remove one unconditional test suite skip for windows (patch 0005); replaced by filter condition in pytest invocation
…da-forge-pinning 2021.04.06.13.31.20
This was referenced Apr 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to debug the errors in the GPU test suite from #19 that lead to yanking the builds, see also this comment