feat: Add macos to build #9
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
@conda-forge-admin, please rerender |
matthewfeickert
commented
May 13, 2024
matthewfeickert
commented
May 13, 2024
matthewfeickert
force-pushed
the
feat/add-macos-builds
branch
from
2640a82
to
1fc0ef6
Compare
|
So, like in conda-forge/staged-recipes#21052, the actual macOS builds are passing, but then failing given and I don't know why, as the Linux builds are fine. For example, for the fastjet-3.4.0.6-cp312-cp312-macosx_10_13_x86_64 wheel added contents:but then the final linking checks fail with Details:From the Shared libraries in macOS and Linux section of the There is the section
Though I don't know what to do with this information in a conda-forge feedstock. edit: Building locally on a mac, I can see that files under % find . -type f -iname _ext.cpython-312-darwin.so
./miniforge3/conda-bld/fastjet_1715613590535/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_place/lib/python3.12/site-packages/fastjet/_ext.cpython-312-darwin.so
./miniforge3/conda-bld/fastjet_1715613590535/work/build/lib.macosx-10.9-x86_64-cpython-312/fastjet/_ext.cpython-312-darwin.so
% otool -L ./miniforge3/conda-bld/fastjet_1715613590535/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_place/lib/python3.12/site-packages/fastjet/_ext.cpython-312-darwin.so
./miniforge3/conda-bld/fastjet_1715613590535/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_place/lib/python3.12/site-packages/fastjet/_ext.cpython-312-darwin.so:
/Users/feickert/Code/GitHub/scikit-hep/conda-forge_feedstocks/fastjet-feedstock/miniforge3/conda-bld/fastjet_1715613590535/work/src/fastjet/_fastjet_core/lib/libfastjet.0.dylib (compatibility version 1.0.0, current version 1.0.0)
/Users/feickert/Code/GitHub/scikit-hep/conda-forge_feedstocks/fastjet-feedstock/miniforge3/conda-bld/fastjet_1715613590535/work/src/fastjet/_fastjet_core/lib/libfastjettools.0.dylib (compatibility version 1.0.0, current version 1.0.0)
/Users/feickert/Code/GitHub/scikit-hep/conda-forge_feedstocks/fastjet-feedstock/miniforge3/conda-bld/fastjet_1715613590535/work/src/fastjet/_fastjet_core/lib/libfastjetcontribfragile.dylib (compatibility version 0.0.0, current version 0.0.0)
@rpath/libc++.1.dylib (compatibility version 1.0.0, current version 1.0.0)
/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1252.0.0)% find . -type f -iname libfastjettools.0.dylib
./miniforge3/conda-bld/fastjet_1715613590535/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_place/lib/python3.12/site-packages/fastjet/_fastjet_core/lib/libfastjettools.0.dylib
./miniforge3/conda-bld/fastjet_1715613590535/work/build/lib.macosx-10.9-x86_64-cpython-312/fastjet/_fastjet_core/lib/libfastjettools.0.dylib
./miniforge3/conda-bld/fastjet_1715613590535/work/fastjet-core/tools/.libs/libfastjettools.0.dylib
./miniforge3/conda-bld/fastjet_1715613590535/work/src/fastjet/_fastjet_core/lib/libfastjettools.0.dylib
% otool -L ./miniforge3/conda-bld/fastjet_1715613590535/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_place/lib/python3.12/site-packages/fastjet/_fastjet_core/lib/libfastjettools.0.dylib
./miniforge3/conda-bld/fastjet_1715613590535/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_place/lib/python3.12/site-packages/fastjet/_fastjet_core/lib/libfastjettools.0.dylib:
/Users/feickert/Code/GitHub/scikit-hep/conda-forge_feedstocks/fastjet-feedstock/miniforge3/conda-bld/fastjet_1715613590535/work/src/fastjet/_fastjet_core/lib/libfastjettools.0.dylib (compatibility version 1.0.0, current version 1.0.0)
/Users/feickert/Code/GitHub/scikit-hep/conda-forge_feedstocks/fastjet-feedstock/miniforge3/conda-bld/fastjet_1715613590535/work/src/fastjet/_fastjet_core/lib/libfastjet.0.dylib (compatibility version 1.0.0, current version 1.0.0)
/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1252.0.0)
@rpath/libc++.1.dylib (compatibility version 1.0.0, current version 1.0.0) |
matthewfeickert
commented
May 13, 2024
| cwd=FASTJET, | ||
| ) | ||
|
|
||
| + # RPATH is set for shared libraries in the following locations: | ||
| + # * fastjet/ | ||
| + # * fastjet/_fastjet_core/lib/ | ||
| + # * fastjet/_fastjet_core/lib/python*/site-packages/ | ||
| + _rpath = "'$$ORIGIN/_fastjet_core/lib:$$ORIGIN:$$ORIGIN/../..'" | ||
| + if sys.platform == "darwin": | ||
| + _rpath = "'$@loader_path/_fastjet_core/lib:$@loader_path:$@loader_path/../..'" |
There was a problem hiding this comment.
$@loader_path doesn't work, so maybe try dropping the $.
3 tasks
|
@conda-forge/help-python-c do you have any advice on why adding |
|
The issue is probably with the RPATH set in I do similar magic in https://github.com/blue-yonder/turbodbc/blob/8d73ee3a5ec6ca0c764f8910903496f513b57f57/setup.py#L100 which worked for me for the last years. |
5 tasks
* Bump build number.
* Using conda-forge this isn't necessary and kills the build.
* gmake is still not available for unix builds of make?
matthewfeickert
force-pushed
the
feat/add-macos-builds
branch
from
0b78fd0
to
600cbf0
Compare
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
@conda-forge-admin, please rerender |
…nda-forge-pinning 2024.08.13.15.51.23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add macos to build matrix.
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)