Apply CUDA 11.8 migrator (manually) #35
Conversation
conda-forge-admin
requested review from
bdice,
gmarkall,
jakirkham and
prashantkhoje
as code owners
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
…nda-forge-pinning 2023.10.16.18.46.05
No longer needed now that there is a CUDA 11.8 build in the matrix that can be used.
|
@conda-forge-admin , please re-render |
…nda-forge-pinning 2023.10.16.18.46.05
|
@conda-forge-admin , please re-render |
Should cutdown on no-op migrations that simply sort the keys in this file.
|
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub actions workflow run https://github.com/conda-forge/ptxcompiler-feedstock/actions/runs/6541760892. |
|
@conda-forge-admin , please re-render |
|
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub actions workflow run https://github.com/conda-forge/ptxcompiler-feedstock/actions/runs/6541786959. |
Rebuild now that the CUDA 11.8 migration is used instead of a `conda_build_config.yaml` file. Also as the GCC version went from 10 to 11.
|
@bdice can you please review? |
| - quay.io/condaforge/linux-anvil-cos7-x86_64 # [linux64 and os.environ.get("BUILD_PLATFORM") == "linux-64"] | ||
| cuda_compiler_version: | ||
| - None | ||
| - 10.2 # [(linux64 or win) and os.environ.get("CF_CUDA_ENABLED", "False") == "True"] |
There was a problem hiding this comment.
Do we still expect to see references to CUDA 10 here?
There was a problem hiding this comment.
Yes, the migrator file comes from here. It is just added to feedstocks as-is. So no customization would happen in this file (only in the recipe)
This particular field is part of the ordering field, which simply specifies how to sort the values for this key and how they relate to other zipped keys (like c_compiler_version or docker_image). It doesn't mean those values are actually used. Just specifying how they relate to each other
In our case here, we skip everything except CUDA 11.8. So that is the only CUDA version relevant for us
|
Yep that is right. Recipe changes are most relevant. Thanks Bradley! 🙏 |
Now that CUDA 11.8 is being added to conda-forge via a CUDA 11.8 migrator ( conda-forge/conda-forge-pinning-feedstock#4834 ). There is no need for the custom
conda_build_config.yamlfile in this recipe. So remove that, apply the CUDA 11.8 migrator, and adjust theskipto only build on CUDA 11.8. Re-rendered after those changes, which kept the builds the same (though made the cosmetic change of naming the builds differently). Largely the recipe is otherwise unchanged. This should allow the CUDA 11.8 migrator to markptxcompileras migrated though, which will allow any downstream packages to be migrated (as well as more accurately reflect the status ofptxcompiler).Hi! This is the friendly automated conda-forge-webservice.
I've started rerendering the recipe as instructed in #34.
If I find any needed changes to the recipe, I'll push them to this PR shortly. Thank you for waiting!
Here's a checklist to do before merging.
Fixes #34