-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
macOS builds fail with segmentation fault #204
Comments
It appears that the same issue is occurring with |
This seems to be more likely a question of the rust setup to me, as it's happening during rust compilation. The log
doesn't tell me anything what failed. In the
which could be explained by the fact that the jnv recipe specifies no host environment |
Now Edit: CC: @conda-forge/rust-activation |
I reran the CI for conda-forge/jnv-feedstock#2 and it seems to pass now. Not sure if conda-forge/rust-activation-feedstock#60 had something to do with it. The release notes mention a miscompilation when comparing floats; no idea if that's applicable in the cases above. |
Still running into the same on conda-forge/tokenizers-feedstock#70 for the Python 3.8 MacOS build. |
Interesting that this only happens with py38, that looks like it involves at least one other problem. Since py38 is about to be dropped in 2 month, I'd be fairly liberal in dropping those builds though. 🤷 |
With @h-vetinari's help, we got conda-forge/tokenizers-feedstock#70 atleast resolved and merged, but I did see CI fail for MacOS on Python 3.12 atleast once, so I suspect this is likely flaky and maybe broader than just Python 3.8. It could also be caching at some layer for an older image causing it, but I'm not confident. |
Should we move this to the rust(-activation) feedstock? |
Has anyone tried using |
Yes, Polars is using |
Is there any update with regard to this issue? Any workarounds? |
Thus far have had success downgrading to the MSRV of the upstream, if available/documented/can be inferred from their CI, e.g.: # conda_build_config.yaml
rust_compiler_version: # [osx]
- "1.74" # [osx] Some feedstocks (like |
This only happens with Sadly
|
I was able to poke around a bit. The culprit seems to be the In my particular sample build of pixi, the contents of that list file are trivial:
(I was able to debug this by manually activating the build environment using I'll fool around a bit more but it doesn't look like Rust is doing anything incredibly unreasonable here — I think we are uncovering a weird update: Even if the list file is completely empty, I get the segfault. So it looks like the problem is with the fundamental handling of that argument. Also, if I pass the argument directly without the |
I was able to attach an Web searching doesn't pull up any obvious reports of crashes associated with update: If I use update 2: OK, if I reorder the project |
That |
@h-vetinari I am leaning towards agreeing that it's a bug in this build of FWIW, the I'm about to wander over to the NumFOCUS project summit so that will be the end of my flailing around today. |
Indeed, neither do I know what TAPI does (though ld64 is the only package depending on it). I had proposed an update in conda-forge/tapi-feedstock#10 a while ago, which seems to have come to life just now. |
TAPI is a library to read |
Full backtrace:
|
Hopefully conda-forge/cctools-and-ld64-feedstock#74 changes something 🤞 |
I have built the linked PR locally and rerun the ruff build, but I still get the same stacktrace:
|
Has anyone tried if an older ld64 version still works?! It's conceivable that this is a bug in v907 specifically. |
@h-vetinari FYI this bug is still hitting conda-forge/deno-feedstock#132, even with the new |
In a local test build of pixi, conda-forge/cctools-and-ld64-feedstock#70 fixes the failure for me. update: in a local test of conda-forge/deno-feedstock#132, the macOS build doesn't succeed, but it gets past the segfault issue in the current version of the PR. |
conda-forge/cctools-and-ld64-feedstock#70 has been merged and has propagated. I've retriggered a few sample builds of the Rust projects that were failing and I think they're working now, so hopefully this issue is fixed. |
Closing as I haven't seen this in a while. Seems like the fix was sufficient. |
from conda-forge/polars-feedstock#253 (comment)
The text was updated successfully, but these errors were encountered: