Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the igrafx mining sdk #24695

Open
wants to merge 56 commits into
base: main
Choose a base branch
from
Open

Adding the igrafx mining sdk #24695

wants to merge 56 commits into from

Conversation

Dourouve
Copy link

@Dourouve Dourouve commented Dec 6, 2023

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/igrafx-mining-sdk) and found some lint.

Here's what I've got...

For recipes/igrafx-mining-sdk:

  • The about section contained an unexpected subsection name. license-family is not a valid subsection name.
  • requirements: run: requests==2.29.0 must contain a space between the name and the pin, i.e. requests ==2.29.0
  • requirements: run: pydruid==0.6.5 must contain a space between the name and the pin, i.e. pydruid ==0.6.5
  • requirements: run: pandas==1.3.5 must contain a space between the name and the pin, i.e. pandas ==1.3.5
  • requirements: run: SQLAlchemy==2.0.12 must contain a space between the name and the pin, i.e. SQLAlchemy ==2.0.12
  • requirements: run: networkx==2.6.3 must contain a space between the name and the pin, i.e. networkx ==2.6.3
  • requirements: run: numpy==1.21.6 must contain a space between the name and the pin, i.e. numpy ==1.21.6
  • requirements: run: toml==0.10.2 must contain a space between the name and the pin, i.e. toml ==0.10.2
  • requirements: run: python-dotenv==0.19.2 must contain a space between the name and the pin, i.e. python-dotenv ==0.19.2
  • requirements: run: pytest==7.3.1 must contain a space between the name and the pin, i.e. pytest ==7.3.1
  • requirements: run: pytest-dependency==0.5.1 must contain a space between the name and the pin, i.e. pytest-dependency ==0.5.1

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/igrafx-mining-sdk) and found it was in an excellent condition.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/igrafx-mining-sdk) and found some lint.

Here's what I've got...

For recipes/igrafx-mining-sdk:

  • requirements: run: SQLAlchemy==2.0.12 must contain a space between the name and the pin, i.e. SQLAlchemy ==2.0.12

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/igrafx-mining-sdk) and found it was in an excellent condition.

@Dourouve
Copy link
Author

@conda-forge/help-python @BastianZim All checks have passed and the requested changes have been made. The recipe is ready for your review. Thanks.

Copy link
Member

@BastianZim BastianZim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple more things.

recipes/igrafx-mining-sdk/meta.yaml Outdated Show resolved Hide resolved
recipes/igrafx-mining-sdk/meta.yaml Outdated Show resolved Hide resolved
recipes/igrafx-mining-sdk/meta.yaml Outdated Show resolved Hide resolved
recipes/igrafx-mining-sdk/meta.yaml Outdated Show resolved Hide resolved
recipes/igrafx-mining-sdk/meta.yaml Outdated Show resolved Hide resolved
recipes/igrafx-mining-sdk/meta.yaml Show resolved Hide resolved
Dourouve and others added 9 commits June 21, 2024 13:56
Co-authored-by: Bastian Zimmermann <10774221+BastianZim@users.noreply.github.com>
Co-authored-by: Bastian Zimmermann <10774221+BastianZim@users.noreply.github.com>
Co-authored-by: Bastian Zimmermann <10774221+BastianZim@users.noreply.github.com>
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/igrafx-mining-sdk) and found some lint.

Here's what I've got...

For recipes/igrafx-mining-sdk:

  • noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

@conda-forge-webservices
Copy link

conda-forge-webservices bot commented Jun 21, 2024

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/igrafx-mining-sdk/meta.yaml) and found it was in an excellent condition.

@Dourouve
Copy link
Author

@conda-forge/help-python @BastianZim I have modified the recipe according to your suggestions. All checks are passing. Thanks.

@Dourouve Dourouve requested a review from BastianZim June 21, 2024 14:26
@Dourouve
Copy link
Author

@conda-forge/help-python @BastianZim
It has been a while months since this package passed. Please review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants