Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add atool2 #25724

Merged
merged 7 commits into from
Aug 2, 2024
Merged

Add atool2 #25724

merged 7 commits into from
Aug 2, 2024

Conversation

jonashaag
Copy link
Contributor

@jonashaag jonashaag commented Mar 13, 2024

I don't know why we need this

/configure --prefix=$BUILD_PREFIX

but it works. It doesn't work with

/configure --prefix=$PREFIX

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/atool2) and found it was in an excellent condition.

@jonashaag jonashaag marked this pull request as ready for review March 14, 2024 10:05
@jonashaag
Copy link
Contributor Author

@conda-forge/staged-recipes ready for review

Copy link

To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks!

@jonashaag
Copy link
Contributor Author

@conda-forge/help-perl

@github-actions github-actions bot added the perl label Mar 14, 2024
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/atool2/meta.yaml) and found it was in an excellent condition.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/atool2/meta.yaml) and found some lint.

Here's what I've got...

For recipes/atool2/meta.yaml:

  • noarch packages can't have skips with selectors. If the selectors are necessary, please remove noarch: generic.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/atool2/meta.yaml) and found it was in an excellent condition.

@jonashaag
Copy link
Contributor Author

@conda-forge/help-perl

recipes/atool2/meta.yaml Outdated Show resolved Hide resolved
Co-authored-by: Filipe <ocefpaf@gmail.com>
# Missing automake
skip: true # [win]
number: 0
# noarch: generic # Re-enable after fixing Windows build
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that noarch packages are built on Linux and installed on macOS and Windows. What is happening with the Windows build here? Anything that is arch specific won't allow this to become a noarch package later.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is missing automake:

Encountered problems while solving:
  - nothing provides requested automake

Could it be the case that noarch: generic packages are not built on Linux?

They are built only on Linux in the feedstock. If you are sure this can be noarch generic, we can ignore that Windows failure and make it noarch here. We just need to be sure there are no compiled stuff there and that the files will be placed in sane directories for all OSes.

Copy link
Contributor Author

@jonashaag jonashaag Aug 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is how it's done for atool (which is an abandoned version of atool2) https://github.com/conda-forge/atool-feedstock/blob/main/recipe/meta.yaml

Which I guess is what you're suggesting here

We just need to be sure there are no compiled stuff there and that the files will be placed in sane directories for all OSes

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original atool seems to be a perl script dropped in a bin directory, right? Did you ever try to use that on Windows? My guess is that it won't work b/c it should be in the %PREFIX%\Library\bin. On Linux and mac that is $PREFIX/bin.

TL;DR I'm not sure how to best make this noarch generic. You can try OS-noarch and build it once for Linux+mac and they another build for Windows. However, all that won't matter here b/c your Windows build is not working. Can you propagate this comment to an issue in the feedstock. We can merge this as-is for now.

@ocefpaf ocefpaf merged commit 1d1dafc into conda-forge:main Aug 2, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants