-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add atool2 #25724
Add atool2 #25724
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge/staged-recipes ready for review |
To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks! |
@conda-forge/help-perl |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/atool2/meta.yaml:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge/help-perl |
Co-authored-by: Filipe <ocefpaf@gmail.com>
# Missing automake | ||
skip: true # [win] | ||
number: 0 | ||
# noarch: generic # Re-enable after fixing Windows build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that noarch packages are built on Linux and installed on macOS and Windows. What is happening with the Windows build here? Anything that is arch specific won't allow this to become a noarch package later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could it be the case that noarch: generic
packages are not built on Linux? This is the failed pipeline https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=991382&view=logs&j=240f1fee-52bc-5498-a14a-8361bde76ba0&t=7c0f8eae-6d6f-51bf-636f-73a1a7fb1bc4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is missing automake:
Encountered problems while solving:
- nothing provides requested automake
Could it be the case that noarch: generic packages are not built on Linux?
They are built only on Linux in the feedstock. If you are sure this can be noarch generic, we can ignore that Windows failure and make it noarch here. We just need to be sure there are no compiled stuff there and that the files will be placed in sane directories for all OSes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is how it's done for atool (which is an abandoned version of atool2) https://github.com/conda-forge/atool-feedstock/blob/main/recipe/meta.yaml
Which I guess is what you're suggesting here
We just need to be sure there are no compiled stuff there and that the files will be placed in sane directories for all OSes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original atool
seems to be a perl script dropped in a bin directory, right? Did you ever try to use that on Windows? My guess is that it won't work b/c it should be in the %PREFIX%\Library\bin
. On Linux and mac that is $PREFIX/bin
.
TL;DR I'm not sure how to best make this noarch generic. You can try OS-noarch and build it once for Linux+mac and they another build for Windows. However, all that won't matter here b/c your Windows build is not working. Can you propagate this comment to an issue in the feedstock. We can merge this as-is for now.
I don't know why we need this
but it works. It doesn't work with
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).