Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cccl recipe (rename from cuda-cccl-impl). #23722

Merged
merged 8 commits into from
Aug 26, 2023
Merged

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Aug 18, 2023

This PR adds the cccl package, which is a rename of the cuda-cccl-impl package (identical contents for now). Due to some upstream reorganization of the CCCL libraries (thrust, cub, libcudacxx) it now makes sense to make cccl the proper name for this user-facing package, instead of cuda-cccl-impl which sounds like an internal "implementation" package.

This rename has been discussed with stakeholders/maintainers here: conda-forge/cuda-cccl-impl-feedstock#2

This rename is being opened as a new staged recipe in accordance with this guide: https://conda-forge.org/docs/orga/guidelines.html#renaming-packages

For reference, the cuda-cccl-impl package was previously added in #21953.

After this PR is merged, I will follow up with a few downstream recipes to update them.

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/cccl) and found it was in an excellent condition.

@bdice
Copy link
Contributor Author

bdice commented Aug 18, 2023

@adibbley Can you comment here to indicate you're willing to be listed as a maintainer?

Also cc: @jakirkham @jrhemstad for visibility

Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Bradley! 🙏

Think we will want to add run_constrained sections to both recipes to prevent clobbering

recipes/cccl/meta.yaml Show resolved Hide resolved
@jakirkham
Copy link
Member

cc @adibbley

@adibbley
Copy link
Contributor

@adibbley Can you comment here to indicate you're willing to be listed as a maintainer?

Yes, thanks!

Co-authored-by: jakirkham <jakirkham@gmail.com>
@bdice
Copy link
Contributor Author

bdice commented Aug 25, 2023

@adibbley @jakirkham Anything else we need here before requesting a final review/merge?

Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Bradley! 🙏

Had a few suggestions below

recipes/cccl/meta.yaml Outdated Show resolved Hide resolved
recipes/cccl/meta.yaml Outdated Show resolved Hide resolved
Comment on lines +6 to +13
mv -v thrust/thrust/cmake ${PREFIX}/lib/cmake/thrust
mv -v cub/cub/cmake ${PREFIX}/lib/cmake/cub
cp -rv libcudacxx/lib/cmake/libcudacxx ${PREFIX}/lib/cmake

cp -rv thrust/thrust ${PREFIX}/include
cp -rv cub/cub ${PREFIX}/include
cp -rv libcudacxx/include/cuda ${PREFIX}/include
cp -rv libcudacxx/include/nv ${PREFIX}/include
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonder if there is a CMake install approach we can use here in the future

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be reworked with CCCL 2.2 which releases from the new monorepo. Let’s keep the status quo for now since this is just renaming a package we have already tested/used a bit and trust.

bdice and others added 2 commits August 25, 2023 20:09
Co-authored-by: jakirkham <jakirkham@gmail.com>
Co-authored-by: jakirkham <jakirkham@gmail.com>
@bdice bdice requested a review from jakirkham August 26, 2023 01:11
@jakirkham jakirkham merged commit 4ea6793 into conda-forge:main Aug 26, 2023
5 checks passed
@jakirkham
Copy link
Member

Thanks Bradley & Alex! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants