-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cccl recipe (rename from cuda-cccl-impl). #23722
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@adibbley Can you comment here to indicate you're willing to be listed as a maintainer? Also cc: @jakirkham @jrhemstad for visibility |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Bradley! 🙏
Think we will want to add run_constrained
sections to both recipes to prevent clobbering
cc @adibbley |
Yes, thanks! |
Co-authored-by: jakirkham <jakirkham@gmail.com>
@adibbley @jakirkham Anything else we need here before requesting a final review/merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Bradley! 🙏
Had a few suggestions below
mv -v thrust/thrust/cmake ${PREFIX}/lib/cmake/thrust | ||
mv -v cub/cub/cmake ${PREFIX}/lib/cmake/cub | ||
cp -rv libcudacxx/lib/cmake/libcudacxx ${PREFIX}/lib/cmake | ||
|
||
cp -rv thrust/thrust ${PREFIX}/include | ||
cp -rv cub/cub ${PREFIX}/include | ||
cp -rv libcudacxx/include/cuda ${PREFIX}/include | ||
cp -rv libcudacxx/include/nv ${PREFIX}/include |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonder if there is a CMake install approach we can use here in the future
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be reworked with CCCL 2.2 which releases from the new monorepo. Let’s keep the status quo for now since this is just renaming a package we have already tested/used a bit and trust.
Co-authored-by: jakirkham <jakirkham@gmail.com>
Co-authored-by: jakirkham <jakirkham@gmail.com>
Thanks Bradley & Alex! 🙏 |
This PR adds the
cccl
package, which is a rename of thecuda-cccl-impl
package (identical contents for now). Due to some upstream reorganization of the CCCL libraries (thrust, cub, libcudacxx) it now makes sense to makecccl
the proper name for this user-facing package, instead ofcuda-cccl-impl
which sounds like an internal "implementation" package.This rename has been discussed with stakeholders/maintainers here: conda-forge/cuda-cccl-impl-feedstock#2
This rename is being opened as a new staged recipe in accordance with this guide: https://conda-forge.org/docs/orga/guidelines.html#renaming-packages
For reference, the
cuda-cccl-impl
package was previously added in #21953.After this PR is merged, I will follow up with a few downstream recipes to update them.
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).