Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the /build/number back to 0 #167

Closed
Tracked by #147
schuylermartin45 opened this issue Oct 1, 2024 · 5 comments · Fixed by #231
Closed
Tracked by #147

Set the /build/number back to 0 #167

schuylermartin45 opened this issue Oct 1, 2024 · 5 comments · Fixed by #231

Comments

@schuylermartin45
Copy link
Collaborator

schuylermartin45 commented Oct 1, 2024

Part of #147 and requires #129

We need the recipe bumper to reset the build number on a version update command.

Example:

build:
  number: 42

Should become:

build:
  number: 0
@ForgottenProgramme
Copy link
Collaborator

@schuylermartin45 , how do you see this working ? should the command be the following:
crm bump-recipe --reset-build-num ?

@schuylermartin45
Copy link
Collaborator Author

No, this is part of the primary update process, not a flag. I guess you could think of it as "by default" reset the build number to zero.

@ForgottenProgramme
Copy link
Collaborator

So will it go like:
crm bump-recipe update-version?

@ForgottenProgramme ForgottenProgramme self-assigned this Nov 6, 2024
@schuylermartin45
Copy link
Collaborator Author

No just crm bump-recipe meta.yaml. The default update path does not require an additional command or flag or option.

@schuylermartin45
Copy link
Collaborator Author

Remember that this ticket is just part of what we plan to do. In the future crm bump-recipe <file> will update the version number, the SHA-256 (if applicable), dependencies, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants