Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing bug: fixture testing_config 's boolify returns True regardless the value #4435

Closed
jaimergp opened this issue Apr 20, 2022 · 2 comments
Labels
locked [bot] locked due to inactivity source::partner created by or for an Anaconda, Inc. partner company stale [bot] marked as stale due to inactivity type::task indicates a change that doesn't pertain to the code itself, e.g. updating CI/CQ, rebuilding package

Comments

@jaimergp
Copy link
Contributor

Can you spot the typo? v is quoted when it shouldn't:

def testing_config(testing_workdir):
def boolify(v):
return True if 'v' == 'true' else False

This makes it return always True in this config:

result = Config(croot=testing_workdir, anaconda_upload=False, verbose=True,
activate=False, debug=False, variant=None, test_run_post=False,
# These bits ensure that default values are used instead of any
# present in ~/.condarc
filename_hashing=filename_hashing_default,
_src_cache_root=_src_cache_root_default,
error_overlinking=boolify(error_overlinking_default),
error_overdepending=boolify(error_overdepending_default),
noarch_python_build_age=noarch_python_build_age_default,
enable_static=boolify(enable_static_default),
no_rewrite_stdout_env=boolify(no_rewrite_stdout_env_default),
ignore_verify_codes=ignore_verify_codes_default,
exit_on_verify_error=exit_on_verify_error_default,
conda_pkg_format=conda_pkg_format_default)

However, some of those are meant to be False:

filename_hashing_default = 'true'
_src_cache_root_default = None
error_overlinking_default = 'false'
error_overdepending_default = 'false'
noarch_python_build_age_default = 0
enable_static_default = 'true'
no_rewrite_stdout_env_default = 'false'
ignore_verify_codes_default = []
exit_on_verify_error_default = False
conda_pkg_format_default = None

@kenodegard kenodegard added type::task indicates a change that doesn't pertain to the code itself, e.g. updating CI/CQ, rebuilding package source::partner created by or for an Anaconda, Inc. partner company labels Apr 26, 2022
@github-actions
Copy link

Hi there, thank you for your contribution!

This issue has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further activity occurs.

If you would like this issue to remain open please:

  1. Verify that you can still reproduce the issue at hand
  2. Comment that the issue is still reproducible and include:
    - What OS and version you reproduced the issue on
    - What steps you followed to reproduce the issue

NOTE: If this issue was closed prematurely, please leave a comment.

Thanks!

@github-actions github-actions bot added the stale [bot] marked as stale due to inactivity label Jun 28, 2023
@jaimergp
Copy link
Contributor Author

The typo was fixed in #4653

@github-project-automation github-project-automation bot moved this to 🏁 Done in 🧭 Planning Jun 28, 2023
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Jun 28, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked [bot] locked due to inactivity source::partner created by or for an Anaconda, Inc. partner company stale [bot] marked as stale due to inactivity type::task indicates a change that doesn't pertain to the code itself, e.g. updating CI/CQ, rebuilding package
Projects
Archived in project
Development

No branches or pull requests

2 participants