Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validate package existence in conda build --test #5614

Closed

Conversation

swap357
Copy link

@swap357 swap357 commented Feb 3, 2025

Description

This PR changes the behavior when no tests are found for a package during conda build. Previously, the code would silently succeed by returning True when no tests were found. This could mask issues where tests were accidentally omitted or misconfigured.

Now, it will raise a CondaBuildUserError with a clear message indicating that no tests were found for the package. This makes the behavior more explicit and helps users identify when they may have accidentally omitted test configurations.

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot
Copy link
Contributor

We require contributors to sign our Contributor License Agreement and we don't have one on file for @swap357.

In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature, merge the PR (conda/infrastructure#1108), and ping the bot to refresh the PR.

@swap357 swap357 closed this Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

2 participants