Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ClientUpdateProposal for IBC v3 #142

Open
alpe opened this issue Jun 2, 2022 · 4 comments
Open

Fix ClientUpdateProposal for IBC v3 #142

alpe opened this issue Jun 2, 2022 · 4 comments
Assignees

Comments

@alpe
Copy link

alpe commented Jun 2, 2022

The the proposal content was changed and simplified!

// ClientUpdateProposal is a governance proposal. If it passes, the substitute
// client's latest consensus state is copied over to the subject client. The proposal
// handler may fail if the subject and the substitute do not match in client and
// chain parameters (with exception to latest height, frozen height, and chain-id).

ClientUpdateProposal https://github.com/cosmos/ibc-go/blob/main/proto/ibc/core/client/v1/client.proto#L43

@daniellarita
Copy link

thanks for taking this one @hashedone ! let us know if you run into any blockers

@hashedone
Copy link
Collaborator

@daniellarita unfortunately more I am reading the code around, the less I am positive I have an idea of what to do. The gov proposals in tgrade are handled in https://github.com/confio/tgrade/blob/v1.0.1/x/twasm/contract/incoming_msgs.go#L61. There is no handler for ClientUpdate, but there is the IBCClientUpdate proposal. I could assume it is the same, considering the IBCClientUpdate seems to match what is in the ClientUpdate, the problem is - if it matches should it be changed right now? Shouldn't it be first properly handled on the binary side? Or maybe there should be a new message ClientUpdate which will be added to tgrade?

For now, my best bet is - ClientUpdate should be changed to IBCClientUpdate and its structure should be aligned. I can do that. I will prepare PR for that, but if something should be understood differently please give me some lead.

@daniellarita
Copy link

Thanks for the update! @alpe @pinosu can you provide @hashedone with some clarification/ feedback on if his approach makes sense? Thanks!

@alpe
Copy link
Author

alpe commented Oct 5, 2022

The ClientUpdateProposal is a new proposal type that does not exists in tgrade yet. When implemented in the contract side, the integration in tgrade can start the contract object back to the proper ibc content type

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants