Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[voting-contract] More status issues #55

Closed
maurolacy opened this issue Jan 31, 2022 · 0 comments · Fixed by #60
Closed

[voting-contract] More status issues #55

maurolacy opened this issue Jan 31, 2022 · 0 comments · Fixed by #60
Assignees
@ueco-jb

Comments

@maurolacy
Copy link
Contributor

maurolacy commented Jan 31, 2022 •
edited
Loading

Found a couple more issues relates to proposal status, while backporting the current fixes in #14
and #16 to cw-plus multisig contracts:

  • vote checks the status field directly (instead of using the current_status helper).
  • close checks the status field directly (instead of using the current_status helper).

When changing these, some tests fails.
@maurolacy maurolacy changed the title [voting-contract] More status bugs [voting-contract] More status issues Jan 31, 2022
@ueco-jb ueco-jb self-assigned this Jan 31, 2022
@ueco-jb ueco-jb mentioned this issue Feb 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ueco-jb ueco-jb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Voting Contract: vote and close uses current status confio/poe-contracts
2 participants
@maurolacy @ueco-jb