Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Ability to output in json from ibc-setup #251

Open
Anmol1696 opened this issue Oct 13, 2022 · 3 comments
Open

feature: Ability to output in json from ibc-setup #251

Anmol1696 opened this issue Oct 13, 2022 · 3 comments

Comments

@Anmol1696
Copy link
Contributor

Overview

Inorder to use ts-relayer as a standalone relayer like hermes, it might make sense to have additional flag of --output <json | yaml | default> for all the queries with ibc-setup *.

Why

To be able to use jq with ibc-setup directly in bash instead of having to create a custom wrapper around the relayer. This will reduce the overhead of running the relayer with the current opperators as well (moving ts-relayer to more production usecases).

Will be a nice to have

@Anmol1696 Anmol1696 changed the title feature: Ability to output in json for ibc-setup feature: Ability to output in json from ibc-setup Oct 13, 2022
@ethanfrey
Copy link
Contributor

I agree, this would be a nice improvement. I don't have time for this now, but happy to review and approve a pr

@Anmol1696
Copy link
Contributor Author

Cool, will try to get this done.

@ethanfrey
Copy link
Contributor

Hmmm... looks like there is no abstraction here, just some console.log stuff. Happy if you make all those lines in inc-setup if statements for two outputs. No need to auto-generate them from some meta-format.

Also, note the verbose/debug logs will always be the same. You can just turn down log level for scripts (via -q), so you only get the final (JSON) output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants