Quickfix: Ensure start epoch of LookupInEpochRequest and MonitoringRequest is in PAD #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masomel
force-pushed
the
handleops-quickfix
branch
from
7a08550
to
6409a1e
Compare
masomel
changed the title
…n PAD Otherwise directory.LookupInEpoch() fails with ErrorDirectory, though a start epoch that is > the latest epoch indicates a malformed client message.
masomel
force-pushed
the
handleops-quickfix
branch
from
6409a1e
to
1758a01
Compare
|
Wouldn't hurt to add a test. |
arlolra
reviewed
Oct 25, 2016
| } | ||
| _, err := d.HandleOps(req) | ||
| if err != ErrorMalformedClientMessage { | ||
| t.Fatal("Expect error", ErrorMalformedClientMessage, "got", err) | ||
| } | ||
|
|
||
| // Send an invalid MonitoringRequest (startEpoch < EndEpoch) |
|
LGTM. |
|
LGTM, too. |
masomel
added a commit
that referenced
this pull request
Oct 25, 2016
- Otherwise directory.LookupInEpoch() fails with ErrorDirectory, though a start epoch that is > the latest epoch indicates a malformed client message. - Closes #108
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise directory.LookupInEpoch() fails with ErrorDirectory, though a start epoch that is > the latest epoch indicates a malformed client message.