From 858e9bf5c7f074cc7998ff52f1decef32d51a1f7 Mon Sep 17 00:00:00 2001 From: Grant Birchmeier Date: Fri, 31 Jan 2025 17:27:02 -0600 Subject: [PATCH 1/2] bugfix in FixToJson example --- Examples/FixToJson/Program.cs | 2 +- RELEASE_NOTES.md | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/Examples/FixToJson/Program.cs b/Examples/FixToJson/Program.cs index d02cedf3e..5cb42e186 100644 --- a/Examples/FixToJson/Program.cs +++ b/Examples/FixToJson/Program.cs @@ -23,7 +23,7 @@ static void FixToJson( { line = line.Trim(); msg.FromString(line, false, sessionDataDictionary, appDataDictionary, msgFactory); - Console.WriteLine(comma + msg.ToJSON(convertEnumsToDescriptions: humanReadableValues)); + Console.WriteLine(comma + msg.ToJSON(appDataDictionary, convertEnumsToDescriptions: humanReadableValues)); comma = ","; } } diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md index 80d93930c..c4eb36fb1 100644 --- a/RELEASE_NOTES.md +++ b/RELEASE_NOTES.md @@ -64,6 +64,7 @@ What's New * #925 - Make ToAdmin() support DoNotSend (zsojma) * #927 - Remove lock from ScreenLog as Console.WriteLine is thread safe and remove unnecessary Dispose call (Rob-Hague) * #926 - don't init FileLog writers until first use (Rob-Hague) +* #931 - bugfix in FixToJson example program ### v1.12.0 From 05bee4d995e5f5529f61d5c4a53bdccbac452c5e Mon Sep 17 00:00:00 2001 From: Grant Birchmeier Date: Fri, 31 Jan 2025 17:40:09 -0600 Subject: [PATCH 2/2] release note tweak for #887 --- RELEASE_NOTES.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md index c4eb36fb1..c496b119a 100644 --- a/RELEASE_NOTES.md +++ b/RELEASE_NOTES.md @@ -27,7 +27,7 @@ What's New * #887 - cleanup/nullable-ize FixValues, Session, DataDictionary, DataDictionaryProvider, Message, MessageCracker, SocketSettings, SslStreamFactory (gbirchmeier) * DataDictionary.CheckIsInGroup is now static - * Get rid of non-static DataDictionary.Validate functions + * Get rid of non-static DataDictionary.Validate functions; callers must use their static variants **Non-breaking changes** * #864 - when multiple threads race to init DefaultMessageFactory,