Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NuGet package naming #627

Open
akamyshanov opened this issue Jul 5, 2020 · 1 comment
Open

NuGet package naming #627

akamyshanov opened this issue Jul 5, 2020 · 1 comment

Comments

@akamyshanov
Copy link
Contributor

akamyshanov commented Jul 5, 2020

First of all, congratulations and thank you for finally publishing the project on NuGet 🎉

I fully understand that this is very subjective, however here are my 2 cents.
I think that the package IDs should have a different naming structure. Typically, dots in .NET world represent namespace or subproject separators. This means that QuickFIXn.FIX4.1 is logically divided into:

  • QuickFIXn (Project name, OK)
  • FIX4 (???)
  • 1 (???)

This is even worse with QuickFIXn.FIX5.0SP2:

  • QuickFIXn
  • FIX5
  • 0SP2

I think that the project and assembly naming structure is much more clear, e.g:

  • QuickFIXn.FIX44 instead of QuickFIXn.FIX4.4
  • QuickFIXn.FIX50SP2 instead of QuickFIXn.FIX5.0SP1

So that FIX44 or FIX50SP2 represent the spec version as a single entity.

I understand that this would break backwards compatibility for those who already downloaded the packages but I strongly believe that it would be better to change the naming in the long run.

@amandengue
Copy link

👍
I totally agree with this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants