Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding a package icon #861

Closed
Rob-Hague opened this issue Jun 28, 2024 · 4 comments · Fixed by #862
Closed

Consider adding a package icon #861

Rob-Hague opened this issue Jun 28, 2024 · 4 comments · Fixed by #862

Comments

@Rob-Hague
Copy link
Contributor

Should make the packages a bit more recognisable/official-looking on nuget.org

Something like this should do it:

diff --git a/QuickFIXn/QuickFix.csproj b/QuickFIXn/QuickFix.csproj
index a5dc869f..eec6b572 100644
--- a/QuickFIXn/QuickFix.csproj
+++ b/QuickFIXn/QuickFix.csproj
@@ -28,11 +28,13 @@
     <IncludeSymbols>true</IncludeSymbols>
     <SymbolPackageFormat>snupkg</SymbolPackageFormat>
     <PackageReadmeFile>README.md</PackageReadmeFile>
+    <PackageIcon>icon.png</PackageIcon>
   </PropertyGroup>

   <ItemGroup>
     <None Include="..\LICENSE" Pack="true" PackagePath=""/>
     <None Include="..\nuget-enclosures\core-readme.md" Pack="true" PackagePath="README.md" />
+    <None Include="..\icon.png" Pack="true" PackagePath=""/>
   </ItemGroup>

   <ItemGroup>
@gbirchmeier
Copy link
Member

You are absolutely right, I will see if we can whip something up for the next release.

@Rob-Hague
Copy link
Contributor Author

You can also try to reserve the "QuickFIXn" prefix: https://learn.microsoft.com/en-gb/nuget/nuget-org/id-prefix-reservation

@gbirchmeier
Copy link
Member

yes, I really ought to do that too, thanks

@gbirchmeier
Copy link
Member

Requested the reservation, we'll see what happens

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants