Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ping timeouts for streams cause Missing status errors. #1367

Closed
jrandolf opened this issue Dec 13, 2024 · 3 comments
Closed

Ping timeouts for streams cause Missing status errors. #1367

jrandolf opened this issue Dec 13, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@jrandolf
Copy link

jrandolf commented Dec 13, 2024

Describe the bug

This can be seen as a feature request or a bug.

If a stream doesn't produce anything for a while and a client's ping timeout passes, the client will stop the stream and error here

looking for a status header (which would not exist because the client stopped the stream due to timeout).

Expected

A client-side error caused by ping timeout.

To Reproduce

Internal code, but the above description should be sufficient.

Environment (please complete the following information):

  • @connectrpc/connect-node version: v2.0.0
  • Frontend framework and version: 19
  • Node.js version: 22

Additional context
This can probably be resolved by throwing a connect error wherever the ping times out.

@jrandolf jrandolf added the bug Something isn't working label Dec 13, 2024
@timostamm
Copy link
Member

Thanks for the report, Randolf.

This can probably be resolved by throwing a connect error wherever the ping times out.

We do, in https://github.com/connectrpc/connect-es/blob/v2.0.0/packages/connect-node/src/http2-session-manager.ts#L667

Can you provide the exact Node version? A reproducible example would be very helpful.

@jrandolf
Copy link
Author

After some more debugging, it appears the timeout is not the problem. The http2 client response stream for some reason resolves with an empty value. I'll debug this further and get back to you.

@jrandolf
Copy link
Author

Figured it out. It was caused by Envoy Gateway timing out my requests. Nothing wrong here!

@jrandolf jrandolf closed this as not planned Won't fix, can't repro, duplicate, stale Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants