Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep HTTP/2 connections alive with ping frames #627

Closed
timostamm opened this issue May 10, 2023 · 1 comment · Fixed by #673
Closed

Keep HTTP/2 connections alive with ping frames #627

timostamm opened this issue May 10, 2023 · 1 comment · Fixed by #673
Labels
enhancement New feature or request

Comments

@timostamm
Copy link
Member

Is your feature request related to a problem? Please describe.
Especially with long-running streams that idle most of the time, it is possible that a connection dies without the client noticing.
If this happens, the Node.js client simply hangs.

Describe the solution you'd like
Send PING frames in an interval to monitor the connection state in all Transports from @bufbuild/connect-node with httpVersion: "2". Raise an error if the peer does not respond within a certain duration.

Additional context
gRCP Core support it, as described in https://github.com/grpc/grpc/blob/master/doc/keepalive.md

@timostamm timostamm added the enhancement New feature or request label May 10, 2023
@fubhy
Copy link
Contributor

fubhy commented May 17, 2023

I was looking for this just now. Perfect timing :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants