Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixpkgs for protoc-gen-es and protoc-gen-connect-es #655

Closed
dezyh opened this issue May 26, 2023 · 2 comments
Closed

nixpkgs for protoc-gen-es and protoc-gen-connect-es #655

dezyh opened this issue May 26, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@dezyh
Copy link

dezyh commented May 26, 2023

Is your feature request related to a problem? Please describe.
As much as I like it, remote code generation is not permitted at my company. We also currently manage all dependencies through nixpkgs. Currently installing protoc-gen-es and protoc-gen-connect-es is a slightly manual process (not managed by nix shell) but through yarn add.

Describe the solution you'd like
It would be much more convenient to have both protoc-gen-es and protoc-gen-connect-es available through nixpkgs.

Please specify whether the request is for Connect for Web or Connect for
Node.js.

Connect for Web (protoc-gen-es & protoc-gen-connect-es)

Additional Context
There are currently a few nixpkgs such as buf, buf-language-server, protoc-gen-connect-go although I do not know if these are officially maintained.

If possible, I would be okay with trying to provide nixpkgs for the above binaries, but I do not personally have the time to maintain them fully (with new releases, etc). I don't personally think it's required that new releases to the above must be released to nixpkgs at the same time. A best effort basis would be sufficient.

If there's any interested, here is the documentation on creating nixpkgs.

@dezyh dezyh added the enhancement New feature or request label May 26, 2023
@timostamm
Copy link
Member

I believe that the other nixpks are community-maintained. Thankfully, @felschr opened a PR to add nixpks in NixOS/nixpkgs#243432. Unfortunately, the PR ran into some of the intricacies of the npm ecosystem that were hopefully resolved.

@dezyh dezyh changed the title nixpkgs for protoc-gen-rs and protoc-gen-connect-es nixpkgs for protoc-gen-es and protoc-gen-connect-es Oct 21, 2023
@srikrsna-buf
Copy link
Member

Closing as NixOS/nixpkgs#243432 was merged for v1 and updated for v2 in NixOS/nixpkgs#333611

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants