Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onchain task for BNB AMB #4538

Closed
9 of 16 tasks
Tracked by #4517
liu-zhipeng opened this issue Jun 19, 2023 · 7 comments · Fixed by #4623
Closed
9 of 16 tasks
Tracked by #4517

Onchain task for BNB AMB #4538

liu-zhipeng opened this issue Jun 19, 2023 · 7 comments · Fixed by #4623
Assignees
Labels
Enhance 🧘 Issue type: Enhancement Request

Comments

@liu-zhipeng
Copy link
Contributor

liu-zhipeng commented Jun 19, 2023

Problem

Replace BNB multichain connector

Context

Action Items

  • HubConnector for Wormhole
  • SpokeConnector for Wormhole
  • Forge Tests: Unit test covering all fuzz cases
  • E2E testing
  • HH tasks for deployment and test
  • Init script
  • deployment at Testnet for initial testing for the Wormhole contracts
  • Deploy Connector for Mainnet
  • Deploy Connector for spoke

Acceptance criteria

  • E2E working at BNB, ARBITRUM, and ETHEREUM (Fork Mainnet).
  • Succesful xcall() via HH tasks
  • Succesful sendMessage() via HH tasks
  • Succesful propagate() via HH tasks
  • Succesful proveAndProcess() via HH tasks
  • Does not double-reconcile transfers ( MessageStatus checks are overridden on new spoke deploy)
  • Does not double-process transfers (should not cause many transfers to be proveAndProcessed again. this will require offchain verification against newly deployed subgraphs)

Fixes #4623

@liu-zhipeng liu-zhipeng added Enhance 🧘 Issue type: Enhancement Request Pri labels Jun 19, 2023
@liu-zhipeng liu-zhipeng self-assigned this Jun 19, 2023
@sanchaymittal sanchaymittal changed the title Axelar Connector Onchain task for BNB AMB Jun 19, 2023
@sanchaymittal sanchaymittal mentioned this issue Jun 19, 2023
3 tasks
@sanchaymittal sanchaymittal added Epic and removed Epic labels Jun 19, 2023
@liu-zhipeng liu-zhipeng linked a pull request Jun 19, 2023 that will close this issue
7 tasks
@rhlsthrm
Copy link
Collaborator

Verified that old message cannot be processed by new connector, so double spend is not an issue.

@rhlsthrm
Copy link
Collaborator

Created forge test, requested review, R4R.

@rhlsthrm
Copy link
Collaborator

Contract is done, need to test on testnet, but Wormhole does not support Goerli. Need to either test on other testnets or mainnet.

@rhlsthrm
Copy link
Collaborator

Verified messaging from BNB to ETH, still verifying ETH to BNB.

@liu-zhipeng liu-zhipeng linked a pull request Jun 30, 2023 that will close this issue
7 tasks
@LayneHaber
Copy link
Contributor

LayneHaber commented Jun 30, 2023

txs + costs:

ETH -> BSC 
 - 0.000254019196160768 ETH ($0.48) paid on ETH 
 - 0.000713894285678591 BNB ($0.17) refund
 - total: $0.31 paid

BSC -> ETH
 - 0.096724973432518598 BNB ($23.07) paid on BSC
 - 0.00510868 ETH           ($9.7) refund
 - total: $13.37
 - txs:
https://etherscan.io/tx/0x580a3dcec415417b949e947e1335b58b6eeb31f128136b48a3b0c35e0570cbfa
https://bscscan.com/tx/0xc5478c6cacb5fffc2ced78201dd1d6e5d7f6e2b3ab41f89c5b30cc4788e51790

@rhlsthrm
Copy link
Collaborator

rhlsthrm commented Jul 5, 2023

Ready for audit, will not deploy and init as part of this task.

@alexwhte
Copy link
Contributor

alexwhte commented Jul 5, 2023

we are moving deployment and testing into separate issue

Deploy Connector for Mainnet
Deploy Connector for spoke
Acceptance criteria
Does not double-reconcile transfers ( MessageStatus checks are overridden on new spoke deploy)
Does not double-process transfers (should not cause many transfers to be proveAndProcessed again. this will require offchain verification against newly deployed subgraphs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhance 🧘 Issue type: Enhancement Request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants