Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate and refactor postCommentIfPR step from github-utils-shared-library #1

Open
oconnormi opened this issue Oct 4, 2018 · 0 comments
Open

Consolidate and refactor postCommentIfPR step from github-utils-shared-library #1

oconnormi opened this issue Oct 4, 2018 · 0 comments

Comments

@oconnormi
Copy link
Member

connexta/github-utils-shared-library has a postCommentIfPR step that should be refactored and simplified. currently it requires wrapping it in a withCredentials step which could be part of the actual comment step instead.

Additionally explore whether the repo organization and name can be retrieved from the scm object in the pipeline instead of being a required input
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@oconnormi