Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notify snapshot manager about committed blocks #184

Closed
Tracked by #266
aakoshh opened this issue Oct 30, 2023 · 0 comments · Fixed by consensus-shipyard/fendermint#389
Closed
Tracked by #266

Notify snapshot manager about committed blocks #184

aakoshh opened this issue Oct 30, 2023 · 0 comments · Fixed by consensus-shipyard/fendermint#389
Assignees
@aakoshh
Labels
s:fendermint

Comments

@aakoshh
Copy link
Contributor

aakoshh commented Oct 30, 2023 •
edited
Loading

Modify App::commit so that it notifies the snapshot manager about every new committed block event, including:

  • BlockHeight, so it can decide whether to snapshot it
  • FvmStateParams which is not in the BlockStore but has to go in the snapshot

The notification is immediate (just writes to STM) and doesn't block anything. We do it in commit so we know that it's already persisted and the notified component will be able to read it.
@aakoshh aakoshh mentioned this issue Dec 19, 2023
Closed
@aakoshh aakoshh self-assigned this Oct 30, 2023
@aakoshh aakoshh mentioned this issue Nov 3, 2023
Merged
@jsoares jsoares transferred this issue from consensus-shipyard/fendermint Dec 19, 2023
@jsoares jsoares closed this as not planned Won't fix, can't repro, duplicate, stale Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aakoshh aakoshh

Labels
s:fendermint
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

FM-357: Notify the snapshot manager about new commits consensus-shipyard/fendermint
2 participants
@jsoares @aakoshh