Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find cleaner solution for rn-memory.js #4

Open
martinheidegger opened this issue Oct 5, 2020 · 3 comments
Open

Find cleaner solution for rn-memory.js #4

martinheidegger opened this issue Oct 5, 2020 · 3 comments
Assignees
@RangerMauve

Comments

@martinheidegger
Copy link
Member

The fix of memory.js added in 6d9193e#diff-82fc0eab67b0f158e508d32809223ce3 and 6d9193e#diff-b9cfc7f2cdf78a7f4b91a753d10865a2R34 requires both the custom implementation and a setup in the package.json: it would be better if there was a cleaner alternative to it. Options I can think of:

  • Send a PR to sodium-js that removes the necessity for this. (low chance to get that clean)
  • Turn this into a polyfill that can be added like require('rn-sodium-memory-polyfill')`
  • Find a polyfill for MessageChannel that can be used as polyfill.
  • Send a PR/Issue to react-native / expo and ask for this to be added.
@RangerMauve
Copy link
Collaborator

About to be merged upstream

@RangerMauve
Copy link
Collaborator

sodium-friends#51

@martinheidegger
Copy link
Member Author

Please close when the sodium-friends issue is closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RangerMauve RangerMauve

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RangerMauve @martinheidegger