Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unix_term::terminal_size uses STDIN_FILENO for isatty instead of configured output #185

Closed
tgolsson opened this issue Sep 24, 2023 · 0 comments · Fixed by #186
Closed

unix_term::terminal_size uses STDIN_FILENO for isatty instead of configured output #185

tgolsson opened this issue Sep 24, 2023 · 0 comments · Fixed by #186

Comments

@tgolsson
Copy link
Contributor

For example;

console/src/unix_term.rs

Lines 49 to 51 in 0567bdc

if libc::isatty(libc::STDOUT_FILENO) != 1 {
return None;
}

Should likely use out.as_raw_fd() instead. I think the same issue might exist in a few other places in that file that don't currently take a Term at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant