Undeprecate escapeArgument(). #1039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Undeprecate escapeArgument and replace error with updated method documentation per consolidation#1023 (comment).
|
Looks good, thanks for the PR. Backport welcome. |
|
Actually running the tests before merging. Must pass, right? |
|
Symfony Process does provide a new |
|
If the new escapeArguement works better than the one that's copied here, we could pull it in as follow-on work. Since your other PR makes the escape method mostly unused, it might not be worth the effort. Up to you if you want to address this in your PR or not. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request:
Summary
Undeprecate
ProcessUtils::escapeArgument()and replaces error with updated methoddocumentation per #1023 (comment).
Should hopefully be able to be backported to 2.x.
Closes #1023.