Merge pull request #101 from IndrajeetPatil/update_vdiffr

update vdiffr tests; remove lazyData; revdepcheck
const-ae · Jun 12, 2021 · 3a8202f · 3a8202f
2 parents c88cab4 + 7fff20f
commit 3a8202f
Show file tree

Hide file tree

Showing 21 changed files with 840 additions and 1,579 deletions.
diff --git a/.github/workflows/check-full.yaml b/.github/workflows/check-full.yaml
@@ -23,12 +23,15 @@ jobs:
           - {os: windows-latest, r: 'release', args: "--no-manual"}
           - {os: windows-latest, r: 'devel', args: "--no-manual"}
           - {os: windows-latest, r: 'oldrel', args: "--no-manual"}
+          - {os: windows-latest, r: '3.6.0', args: "--no-manual"}
           - {os: macOS-latest, r: 'release', args: "--no-manual"}
           #- {os: macOS-latest, r: 'devel', args: "--no-manual"}
           - {os: macOS-latest, r: 'oldrel', args: "--no-manual"}
+          - {os: macOS-latest, r: '3.6.0', args: "--no-manual"}
           - {os: ubuntu-16.04, r: 'release', cran: "https://demo.rstudiopm.com/all/__linux__/xenial/latest", args: "--no-manual"}
           - {os: ubuntu-16.04, r: 'devel', cran: "https://demo.rstudiopm.com/all/__linux__/xenial/latest", args: "--no-manual"}
           - {os: ubuntu-16.04, r: 'oldrel', cran: "https://demo.rstudiopm.com/all/__linux__/xenial/latest", args: "--no-manual"}
+          - {os: ubuntu-16.04, r: '3.6.0', cran: "https://demo.rstudiopm.com/all/__linux__/xenial/latest", args: "--no-manual"}
 
     env:
       R_REMOTES_NO_ERRORS_FROM_WARNINGS: true

diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,7 +1,7 @@
 Type: Package
 Package: ggsignif
 Title: Significance Brackets for 'ggplot2'
-Version: 0.6.1.9000
+Version: 0.6.2
 Authors@R: 
   c(
     person(given = "Constantin",
@@ -29,7 +29,6 @@ URL: https://const-ae.github.io/ggsignif/,
 VignetteBuilder: 
     knitr
 Encoding: UTF-8
-LazyData: true
 Language: en-US
 Imports:
     ggplot2 (>= 3.3.3)
@@ -38,7 +37,7 @@ Suggests:
     rmarkdown,
     spelling,
     testthat,
-    vdiffr,
+    vdiffr (>= 1.0.0)
 Roxygen: list(markdown = TRUE, roclets = c("rd", "namespace", "collate"))
 RoxygenNote: 7.1.1.9001
 Config/testthat/edition: 3

diff --git a/NEWS.md b/NEWS.md
@@ -1,4 +1,8 @@
-# Version 0.6.1.9000
+# Version 0.6.2
+
+- Updates visual regression tests for `vdiffr 1.0.0` release.
+
+- Removes `NOTE` about `lazyData` from CRAN's daily checks.
 
 # Version 0.6.1
 

diff --git a/README.Rmd b/README.Rmd
@@ -16,13 +16,14 @@ output: github_document
 knitr::opts_chunk$set(
   collapse = TRUE,
   comment = "#>",
+  out.width = "100%",
   fig.path = "man/figures/README-",
   message = FALSE,
   warning = FALSE
 )
 ```
 
-## Description
+## Introduction
 
 This package provides an easy way to indicate if two groups are significantly
 different. Commonly this is shown by a bar on top connecting the groups of
@@ -126,13 +127,17 @@ You can ignore the warning about the missing aesthetics.
 
 For further details go the [CRAN page](https://CRAN.R-project.org/package=ggsignif) and check the examples in the [vignette](https://CRAN.R-project.org/package=ggsignif/vignettes/intro.html).
 
+## Also see
+
+- [`pairwiseComparisons`](https://indrajeetpatil.github.io/pairwiseComparisons/)
+
 ## Maintenance
 
-This package is provided as is and I currently don't have any plans and the
+This package is provided as is and we currently don't have any plans and the
 capacity to add any new features to it. If there is nonetheless a feature which
 you would like to see in the package, you are always welcome to submit pull
-request, which I will try to address as soon as possible.
+request, which we will try to address as soon as possible.
 
 ## Code of Conduct
 
-Please note that the ggsignif project is released with a [Contributor Code of Conduct](https://const-ae.github.io/ggsignif/CODE_OF_CONDUCT.html). By contributing to this project, you agree to abide by its terms.
+Please note that the `ggsignif` project is released with a [Contributor Code of Conduct](https://const-ae.github.io/ggsignif/CODE_OF_CONDUCT.html). By contributing to this project, you agree to abide by its terms.
diff --git a/README.md b/README.md
@@ -11,7 +11,7 @@ coverage](https://codecov.io/gh/const-ae/ggsignif/branch/master/graph/badge.svg)
 
 <!-- README.md is generated from README.Rmd. Please edit that file -->
 
-## Description
+## Introduction
 
 This package provides an easy way to indicate if two groups are
 significantly different. Commonly this is shown by a bar on top
@@ -28,21 +28,20 @@ following command in your R console:
 ``` r
 citation("ggsignif")
 #> 
-#> To cite 'ggsignif' in publications use:
+#> To cite package 'ggsignif' in publications use:
 #> 
-#>   Ahlmann-Eltze, C., & Patil, I. (2021). ggsignif: R Package for
-#>   Displaying Significance Brackets for 'ggplot2'. PsyArxiv.
-#>   doi:10.31234/osf.io/7awm6
+#>   Constantin Ahlmann-Eltze and Indrajeet Patil (2021). ggsignif:
+#>   Significance Brackets for 'ggplot2'. R package version 0.6.1.
+#>   https://CRAN.R-project.org/package=ggsignif
 #> 
 #> A BibTeX entry for LaTeX users is
 #> 
-#>   @Article{,
-#>     title = {{ggsignif}: R Package for Displaying Significance Brackets for {'ggplot2'}},
-#>     author = {Ahlmann-Eltze Constantin and Indrajeet Patil},
+#>   @Manual{,
+#>     title = {ggsignif: Significance Brackets for 'ggplot2'},
+#>     author = {Constantin Ahlmann-Eltze and Indrajeet Patil},
 #>     year = {2021},
-#>     journal = {PsyArxiv},
-#>     url = {https://psyarxiv.com/7awm6},
-#>     doi = {10.31234/osf.io/7awm6},
+#>     note = {R package version 0.6.1},
+#>     url = {https://CRAN.R-project.org/package=ggsignif},
 #>   }
 ```
 
@@ -76,7 +75,7 @@ ggplot(mpg, aes(class, hwy)) +
   ylim(NA, 48)
 ```
 
-![](man/figures/README-simpe_comparison-1.png)<!-- -->
+<img src="man/figures/README-simpe_comparison-1.png" width="100%" />
 
 Setting the precise location
 
@@ -100,7 +99,7 @@ ggplot(iris, aes(x = Species, y = Sepal.Width, fill = Petal.Width > 1)) +
   )
 ```
 
-![](man/figures/README-dodge_comparison-1.png)<!-- -->
+<img src="man/figures/README-dodge_comparison-1.png" width="100%" />
 
 Advanced Example
 
@@ -135,7 +134,7 @@ ggplot(diamonds, aes(x = cut, y = carat)) +
   ylim(NA, 5.3)
 ```
 
-![](man/figures/README-faceted_comparison-1.png)<!-- -->
+<img src="man/figures/README-faceted_comparison-1.png" width="100%" />
 
 You can ignore the warning about the missing aesthetics.
 
@@ -144,17 +143,21 @@ page](https://CRAN.R-project.org/package=ggsignif) and check the
 examples in the
 [vignette](https://CRAN.R-project.org/package=ggsignif/vignettes/intro.html).
 
+## Also see
+
+-   [`pairwiseComparisons`](https://indrajeetpatil.github.io/pairwiseComparisons/)
+
 ## Maintenance
 
-This package is provided as is and I currently don’t have any plans and
+This package is provided as is and we currently don’t have any plans and
 the capacity to add any new features to it. If there is nonetheless a
 feature which you would like to see in the package, you are always
-welcome to submit pull request, which I will try to address as soon as
+welcome to submit pull request, which we will try to address as soon as
 possible.
 
 ## Code of Conduct
 
-Please note that the ggsignif project is released with a [Contributor
+Please note that the `ggsignif` project is released with a [Contributor
 Code of
 Conduct](https://const-ae.github.io/ggsignif/CODE_OF_CONDUCT.html). By
 contributing to this project, you agree to abide by its terms.
diff --git a/cran-comments.md b/cran-comments.md
@@ -1,5 +1,5 @@
 ## Test environments
-* macOS Mojave: R 4.0.3
+* macOS Mojave: R 4.1.0
 
 * GitHub actions (macOS R-devel, macOS R-release, macOS R-oldrel, Windows
   R-release, Windows R-devel, macOS R-oldrel)

diff --git a/revdep/README.md b/revdep/README.md
@@ -2,65 +2,47 @@
 
 |field    |value                        |
 |:--------|:----------------------------|
-|version  |R version 4.0.4 (2021-02-15) |
+|version  |R version 4.1.0 (2021-05-18) |
 |os       |macOS Mojave 10.14.6         |
 |system   |x86_64, darwin17.0           |
 |ui       |RStudio                      |
 |language |(EN)                         |
 |collate  |en_US.UTF-8                  |
 |ctype    |en_US.UTF-8                  |
 |tz       |Europe/Berlin                |
-|date     |2021-02-22                   |
+|date     |2021-06-12                   |
 
 # Dependencies
 
-|package      |old    |new        |Δ  |
-|:------------|:------|:----------|:--|
-|ggsignif     |0.6.0  |0.6.0.9000 |*  |
-|assertthat   |0.2.1  |0.2.1      |   |
-|brio         |1.1.1  |1.1.1      |   |
-|callr        |3.5.1  |3.5.1      |   |
-|cli          |2.3.0  |2.3.0      |   |
-|colorspace   |2.0-0  |2.0-0      |   |
-|crayon       |1.4.1  |1.4.1      |   |
-|desc         |1.2.0  |1.2.0      |   |
-|diffobj      |0.3.3  |0.3.3      |   |
-|digest       |0.6.27 |0.6.27     |   |
-|ellipsis     |0.3.1  |0.3.1      |   |
-|evaluate     |0.14   |0.14       |   |
-|fansi        |0.4.2  |0.4.2      |   |
-|farver       |2.0.3  |2.0.3      |   |
-|ggplot2      |3.3.3  |3.3.3      |   |
-|glue         |1.4.2  |1.4.2      |   |
-|gtable       |0.3.0  |0.3.0      |   |
-|isoband      |0.2.3  |0.2.3      |   |
-|jsonlite     |1.7.2  |1.7.2      |   |
-|labeling     |0.4.2  |0.4.2      |   |
-|lifecycle    |1.0.0  |1.0.0      |   |
-|magrittr     |2.0.1  |2.0.1      |   |
-|munsell      |0.5.0  |0.5.0      |   |
-|pillar       |1.4.7  |1.4.7      |   |
-|pkgbuild     |1.2.0  |1.2.0      |   |
-|pkgconfig    |2.0.3  |2.0.3      |   |
-|pkgload      |1.1.0  |1.1.0      |   |
-|praise       |1.0.0  |1.0.0      |   |
-|prettyunits  |1.1.1  |1.1.1      |   |
-|processx     |3.4.5  |3.4.5      |   |
-|ps           |1.5.0  |1.5.0      |   |
-|R6           |2.5.0  |2.5.0      |   |
-|RColorBrewer |1.1-2  |1.1-2      |   |
-|rematch2     |2.1.2  |2.1.2      |   |
-|rlang        |0.4.10 |0.4.10     |   |
-|rprojroot    |2.0.2  |2.0.2      |   |
-|rstudioapi   |0.13   |0.13       |   |
-|scales       |1.1.1  |1.1.1      |   |
-|testthat     |3.0.2  |3.0.2      |   |
-|tibble       |3.0.6  |3.0.6      |   |
-|utf8         |1.1.4  |1.1.4      |   |
-|vctrs        |0.3.6  |0.3.6      |   |
-|viridisLite  |0.3.0  |0.3.0      |   |
-|waldo        |0.2.4  |0.2.4      |   |
-|withr        |2.4.1  |2.4.1      |   |
+|package      |old    |new    |Δ  |
+|:------------|:------|:------|:--|
+|ggsignif     |0.6.1  |0.6.2  |*  |
+|cli          |2.5.0  |2.5.0  |   |
+|colorspace   |2.0-1  |2.0-1  |   |
+|crayon       |1.4.1  |1.4.1  |   |
+|digest       |0.6.27 |0.6.27 |   |
+|ellipsis     |0.3.2  |0.3.2  |   |
+|fansi        |0.5.0  |0.5.0  |   |
+|farver       |2.1.0  |2.1.0  |   |
+|ggplot2      |3.3.3  |3.3.3  |   |
+|glue         |1.4.2  |1.4.2  |   |
+|gtable       |0.3.0  |0.3.0  |   |
+|isoband      |0.2.4  |0.2.4  |   |
+|labeling     |0.4.2  |0.4.2  |   |
+|lifecycle    |1.0.0  |1.0.0  |   |
+|magrittr     |2.0.1  |2.0.1  |   |
+|munsell      |0.5.0  |0.5.0  |   |
+|pillar       |1.6.1  |1.6.1  |   |
+|pkgconfig    |2.0.3  |2.0.3  |   |
+|R6           |2.5.0  |2.5.0  |   |
+|RColorBrewer |1.1-2  |1.1-2  |   |
+|rlang        |0.4.11 |0.4.11 |   |
+|scales       |1.1.1  |1.1.1  |   |
+|tibble       |3.1.2  |3.1.2  |   |
+|utf8         |1.2.1  |1.2.1  |   |
+|vctrs        |0.3.8  |0.3.8  |   |
+|viridisLite  |0.4.0  |0.4.0  |   |
+|withr        |2.4.2  |2.4.2  |   |
 
 # Revdeps
 
diff --git a/revdep/cran.md b/revdep/cran.md
@@ -1,7 +1,6 @@
 ## revdepcheck results
 
-We checked 4 reverse dependencies (2 from CRAN + 2 from Bioconductor), comparing
-R CMD check results across CRAN and dev versions of this package.
+We checked 4 reverse dependencies (2 from CRAN + 2 from Bioconductor), comparing R CMD check results across CRAN and dev versions of this package.
 
  * We saw 0 new problems
  * We failed to check 0 packages