Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch flag/unflag buttons on use via ajax #1883

Merged
merged 3 commits into from
Sep 20, 2017

Conversation

xarlybovi
Copy link
Contributor

Where

What

  • Refresh proposal flag/unflag button via AJAX

How

  • Implemented like follow/unfollow button and reloaded foundation in order to fix dropdown on AJAX partial render

@voodoorai2000
Copy link
Member

This is great @xarlybovi!

A small detail, the flaggable concern is used by another two models, debates and comments.

Could you use resource_id instead of proposal_id and add a couple of specs to make sure these changes fix the problem?

@xarlybovi
Copy link
Contributor Author

Yeah, sure!

@xarlybovi
Copy link
Contributor Author

@voodoorai2000 Done.

@voodoorai2000
Copy link
Member

Great! Appreciate it @xarlybovi

@voodoorai2000 voodoorai2000 merged commit b416d28 into consuldemocracy:master Sep 20, 2017
javierm pushed a commit to javierm/consul that referenced this pull request Mar 6, 2019
…ct_common_code_from_custom_partial

Extract shared code from custom partial
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants