Iagirre autocomplete tags #1905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 19, 2017 17:37
Cambios para hacer commit: modificado: app/assets/javascripts/tag_autocomplete.js.coffee modificado: app/assets/stylesheets/autocomplete_overrides.scss nuevo archivo: app/controllers/tags_controller.rb modificado: app/models/abilities/common.rb modificado: app/views/debates/_form.html.erb modificado: app/views/proposals/_form.html.erb modificado: config/initializers/acts_as_taggable_on.rb modificado: config/routes.rb modificado: spec/lib/acts_as_taggable_on_spec.rb
|
Hi @iagirre! Thanks for the PR! 👍 For the scss file |
decabeza
approved these changes
Sep 26, 2017
This was referenced Sep 26, 2017
Closed
javierm
pushed a commit
to javierm/consul
that referenced
this pull request
Mar 18, 2019
…ing_proposals_validations Migrate special supports and votes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Where
What
When the user is writting the tags for a proposal, a debate or an investment project, the page should suggest other tags that already exist so that users can select those tags instead of creating new and similiar ones (e.g. motorbike and motorcycle).
How
I used the autocomplete widget from
jquery-uito do it. When the user is writing, the widget looks for similar words in the DB using thepg_searchgem. The gem retrieves the results and they are shown in a list under the text field. The user can select one of the results using the mouse or the down and up arrows on the keyboard. When an option is selected, it is automatically added to the list.Screenshots
Test
I increased the test coverage for the tags' search function.
Deployment
Not to apply
Warnings
Not to apply