Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds poll comments to API #2148

Merged
merged 1 commit into from
Nov 21, 2017
Merged

adds poll comments to API #2148

merged 1 commit into from
Nov 21, 2017

Conversation

xuanxu
Copy link
Contributor

@xuanxu xuanxu commented Nov 21, 2017

Where

What

  • This PR adds polls' comments to the graphql API

How

  • As stated in the original issue only the comments are exposed, the Poll model is not included in the API interface.

Test

  • Specs updated

Deployment

  • none

Warnings

  • none

bertocq
bertocq approved these changes Nov 21, 2017
View reviewed changes
Copy link
Collaborator

@bertocq bertocq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So glad to have you back 👏 🤗

@bertocq bertocq merged commit 5355c0f into master Nov 21, 2017
@bertocq bertocq deleted the poll_comments_to_api branch November 21, 2017 15:07
This was referenced Nov 21, 2017
Closed
Merged
@voodoorai2000
Copy link
Member

❤️

@bertocq bertocq mentioned this pull request Nov 21, 2017
Merged
clairezed pushed a commit to CDJ11/CDJ that referenced this pull request Jun 26, 2018
@bertocq
Merge pull request consuldemocracy#2148 from consul/poll_comments_to_api
0850741 
adds poll comments to API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bertocq bertocq bertocq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xuanxu @voodoorai2000 @bertocq