Feature flag api #2151
Merged
Feature flag api #2151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ouch! I've just noticed another PR implementing this feature. Sorry, I saw the issue a couple days ago. I keep this PR open because I've realized that the implementation is different, but feel free to close it at will. |
|
Don't worry @xuanxu :), we're scheduling this for release v0.12 (currently we're trying to close v0.11) and we'll get a mix of both, as for example at itziar PR #2146 we like the fact that it returns a clear |
|
Thank you @xuanxu 😌 |
javierm
force-pushed
the
feature-flag-api
branch
from
bc4af79 to
0063e7b
Compare
|
Hehe, I’ll keep an eye on it 😁 |
smarques
pushed a commit
to venetochevogliamo/consul
that referenced
this pull request
Apr 29, 2020
Feature flag api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Objectives
Add a feature flag for the GraphQL API