Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused and obsolete code #3718

Merged
merged 9 commits into from
Sep 25, 2019
Merged

Remove unused and obsolete code #3718

merged 9 commits into from
Sep 25, 2019

Conversation

javierm
Copy link
Member

@javierm javierm commented Sep 24, 2019

Objectives

  • Remove useless code we've accidentally left
  • Reduce the number of unused variable warnings given by the Ruby interpreter

@javierm
Remove obsolete notices in booth assignments
f767f23 
This code is obsolete since commit 085e6ec.
@javierm
Remove obsolete poll answers variable
0603093 
This code is obsolete since commit c6e4b24.
@javierm
Remove obsolete confirm messages references
748ee3d 
This code is obsolete since commits 122b170 and bbf3faa.
@javierm javierm self-assigned this Sep 24, 2019
@javierm
Remove obsolete data creation
fb6d12c 
This data is obsolete since commit 9d1ca3b.

Note we should have probably moved the test to the model, since now the
`to_csv` method isn't tested anywhwere, and we should probably add a
test in the future. The code now uses the new DownloadSetting model,
though, making it hard to test.
@javierm
Remove obsolete URL reference
fcaa30d 
This URL was accidentally copied from Madrid's repository. However, we
don't use it in CONSUL.
@javierm
Remove unnecessary code
cb20698 
It looks like these variables were left by accident. The Ruby
interpreter was giving us warnings about unused variables.
@javierm javierm force-pushed the remove_obsolete_code branch from 3b3e2eb to cb20698 Compare September 24, 2019 16:49
@javierm
Remove commented graphql tests
82ea866 
These tests use a "proceeding" method in proposals, which does not
exist.
@javierm
Remove commented graphql code
da425b9 
This code was commented in commit ad8aba0.
@javierm
Remove useless parameter in URL
9fcea17 
The proposal parameter was accidentally added in commit 16692c9, but
the proposals index doesn't receive a proposal as parameter.
@javierm javierm changed the title Remove unused and unnecessary code Remove unused and obsolete code Sep 24, 2019
@javierm javierm mentioned this pull request Sep 24, 2019
Merged
@javierm javierm merged commit 8d41114 into master Sep 25, 2019
@javierm javierm deleted the remove_obsolete_code branch September 25, 2019 09:46
@javierm javierm mentioned this pull request Sep 26, 2019
Merged
smarques pushed a commit to venetochevogliamo/consul that referenced this pull request Apr 29, 2020
@javierm
Merge pull request consuldemocracy#3718 from consul/remove_obsolete_code
0f15baa 
Remove unused and obsolete code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@javierm javierm

Labels
Refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@javierm